From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
drbd-dev@lists.linbit.com
Subject: Re: improve the bio cloning interface
Date: Thu, 27 Jan 2022 11:52:51 -0500 [thread overview]
Message-ID: <YfLN4/2bYe4hebCy@redhat.com> (raw)
In-Reply-To: <20220127063546.1314111-1-hch@lst.de>
On Thu, Jan 27 2022 at 1:35P -0500,
Christoph Hellwig <hch@lst.de> wrote:
> Hi Jens,
>
> this series changes the bio cloning interface to match the rest changes
> to the bio allocation interface and passes the block_device and operation
> to the cloning helpers. In addition it renames the cloning helpers to
> be more descriptive.
>
> To get there it requires a bit of refactoring in the device mapper code.
I'd like to take a closer look, do you happen to have this series
available in a git branch?
The changes generally look fine. Any chance you could forecast what
you're planning for follow-on changes?
Or is it best to just wait for you to produce those follow-on changes?
Thanks,
Mike
next prev parent reply other threads:[~2022-01-27 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 6:35 improve the bio cloning interface Christoph Hellwig
2022-01-27 6:35 ` [PATCH 01/14] drbd: set ->bi_bdev in drbd_req_new Christoph Hellwig
2022-01-27 6:35 ` [PATCH 02/14] dm: add a clone_to_tio helper Christoph Hellwig
2022-01-27 6:35 ` [PATCH 03/14] dm: fold clone_bio into __clone_and_map_data_bio Christoph Hellwig
2022-01-27 6:35 ` [PATCH 04/14] dm: fold __send_duplicate_bios into __clone_and_map_simple_bio Christoph Hellwig
2022-01-27 6:35 ` [PATCH 05/14] dm: move cloning the bio into alloc_tio Christoph Hellwig
2022-01-27 6:35 ` [PATCH 06/14] dm: pass the bio instead of tio to __map_bio Christoph Hellwig
2022-01-27 6:35 ` [PATCH 07/14] dm: retun the clone bio from alloc_tio Christoph Hellwig
2022-01-27 6:35 ` [PATCH 08/14] dm: simplify the single bio fast path in __send_duplicate_bios Christoph Hellwig
2022-01-27 6:35 ` [PATCH 09/14] dm: add a missing bio initialization to alloc_tio Christoph Hellwig
2022-01-27 6:35 ` [PATCH 10/14] dm-cache: remove __remap_to_origin_clear_discard Christoph Hellwig
2022-01-27 6:35 ` [PATCH 11/14] block: clone crypto and integrity data in __bio_clone_fast Christoph Hellwig
2022-01-27 6:35 ` [PATCH 12/14] dm: use bio_clone_fast in alloc_tio Christoph Hellwig
2022-01-27 6:35 ` [PATCH 13/14] block: initialize the target bio in __bio_clone_fast Christoph Hellwig
2022-01-27 6:35 ` [PATCH 14/14] block: pass a block_device to bio_clone_fast Christoph Hellwig
2022-01-27 16:52 ` Mike Snitzer [this message]
2022-01-27 19:58 ` improve the bio cloning interface Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfLN4/2bYe4hebCy@redhat.com \
--to=snitzer@redhat.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).