From: Mike Snitzer <snitzer@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Lars Ellenberg <lars.ellenberg@linbit.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
drbd-dev@lists.linbit.com
Subject: Re: improve the bio cloning interface v2
Date: Wed, 2 Feb 2022 14:42:33 -0500 [thread overview]
Message-ID: <YfreqbCOPYFrQm73@redhat.com> (raw)
In-Reply-To: <20220202160109.108149-1-hch@lst.de>
On Wed, Feb 02 2022 at 11:00P -0500,
Christoph Hellwig <hch@lst.de> wrote:
> Hi Jens,
>
> this series changes the bio cloning interface to match the rest changes
> to the bio allocation interface and passes the block_device and operation
> to the cloning helpers. In addition it renames the cloning helpers to
> be more descriptive.
>
> To get there it requires a bit of refactoring in the device mapper code.
>
> Changes since v1:
> - rebased to the lastest for-5.18/block tree
> - fix a fatal double initialization in device mapper
>
> A git tree is also available here:
>
> git://git.infradead.org/users/hch/block.git bio_alloc-cleanup-part2
>
> Gitweb:
>
> http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/bio_alloc-cleanup-part2
>
> Diffstat:
> Documentation/block/biodoc.rst | 5 -
> block/bio-integrity.c | 1
> block/bio.c | 106 +++++++++++++-----------
> block/blk-crypto.c | 1
> block/blk-mq.c | 4
> block/bounce.c | 3
> drivers/block/drbd/drbd_req.c | 5 -
> drivers/block/drbd/drbd_worker.c | 4
> drivers/block/pktcdvd.c | 4
> drivers/md/bcache/request.c | 6 -
> drivers/md/dm-cache-target.c | 26 ++----
> drivers/md/dm-crypt.c | 11 +-
> drivers/md/dm-zoned-target.c | 3
> drivers/md/dm.c | 166 +++++++++++++--------------------------
> drivers/md/md-faulty.c | 4
> drivers/md/md-multipath.c | 4
> drivers/md/md.c | 5 -
> drivers/md/raid1.c | 34 +++----
> drivers/md/raid10.c | 16 +--
> drivers/md/raid5.c | 4
> fs/btrfs/extent_io.c | 4
> include/linux/bio.h | 6 -
> 22 files changed, 183 insertions(+), 239 deletions(-)
>
Looks good, for all:
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
I have some DM core changes for 5.18 that I need to make and this
patchset offers enough DM churn that I'd like to base my changes
ontop. So I'd appreciate it if this patchset could land in block's
for-5.18 ASAP.
Thanks,
Mike
next prev parent reply other threads:[~2022-02-02 19:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 16:00 improve the bio cloning interface v2 Christoph Hellwig
2022-02-02 16:00 ` [PATCH 01/13] drbd: set ->bi_bdev in drbd_req_new Christoph Hellwig
2022-02-02 16:00 ` [PATCH 02/13] dm: add a clone_to_tio helper Christoph Hellwig
2022-02-02 16:00 ` [PATCH 03/13] dm: fold clone_bio into __clone_and_map_data_bio Christoph Hellwig
2022-02-02 16:01 ` [PATCH 04/13] dm: fold __send_duplicate_bios into __clone_and_map_simple_bio Christoph Hellwig
2022-02-02 16:01 ` [PATCH 05/13] dm: move cloning the bio into alloc_tio Christoph Hellwig
2022-02-02 16:01 ` [PATCH 06/13] dm: pass the bio instead of tio to __map_bio Christoph Hellwig
2022-02-02 16:01 ` [PATCH 07/13] dm: retun the clone bio from alloc_tio Christoph Hellwig
2022-02-02 18:33 ` Mike Snitzer
2022-02-02 16:01 ` [PATCH 08/13] dm: simplify the single bio fast path in __send_duplicate_bios Christoph Hellwig
2022-02-02 16:01 ` [PATCH 09/13] dm-cache: remove __remap_to_origin_clear_discard Christoph Hellwig
2022-02-02 16:01 ` [PATCH 10/13] block: clone crypto and integrity data in __bio_clone_fast Christoph Hellwig
2022-02-02 16:01 ` [PATCH 11/13] dm: use bio_clone_fast in alloc_io/alloc_tio Christoph Hellwig
2022-02-02 16:01 ` [PATCH 12/13] block: initialize the target bio in __bio_clone_fast Christoph Hellwig
2022-02-02 16:01 ` [PATCH 13/13] block: pass a block_device to bio_clone_fast Christoph Hellwig
2022-02-02 19:42 ` Mike Snitzer [this message]
2022-02-04 14:43 ` improve the bio cloning interface v2 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfreqbCOPYFrQm73@redhat.com \
--to=snitzer@redhat.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).