From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@infradead.org>,
"Wang Jianchao (Kuaishou)" <jianchao.wan9@gmail.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk: do rq_qos_exit in blk_cleanup_queue
Date: Thu, 17 Feb 2022 07:48:33 -0800 [thread overview]
Message-ID: <Yg5uUeMONPn4jnng@infradead.org> (raw)
In-Reply-To: <eb8e2477-d8f6-b032-6177-8ce187de12ab@kernel.dk>
On Thu, Feb 17, 2022 at 07:55:16AM -0700, Jens Axboe wrote:
> > from Jan 22. Although it would need a rebase so it can be applied
> > without the preceding patches.
>
> Can someone respin that for 5.17 then?
I looked at it and it I don't think we can do that without a lot of
the prep patches.
That being said I think this version of the patch also is buggy, we
want the policies shut down in del_gendisk with the queue frozen for
normal operation.
I guess until we can move the initialization and teardown entirely
to the gendisk as in Ming's more complex series we need to keep the
call in del_gendisk and also do it in blk_cleanup_queue. For the
normal shutdown on disk that were life del_gendisk does the all the
work on the frozen queue, while for queues that never had a disk
blk_cleanup_queue will clean up the unused rq_qos.
prev parent reply other threads:[~2022-02-17 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 11:32 [PATCH] blk: do rq_qos_exit in blk_cleanup_queue Wang Jianchao (Kuaishou)
2022-02-16 18:25 ` Bart Van Assche
2022-02-17 2:40 ` Jens Axboe
2022-02-17 7:48 ` Christoph Hellwig
2022-02-17 13:34 ` Jens Axboe
2022-02-17 14:03 ` Christoph Hellwig
2022-02-17 14:55 ` Jens Axboe
2022-02-17 15:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg5uUeMONPn4jnng@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jianchao.wan9@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).