From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Li Ning <lining2020x@163.com>,
Tejun Heo <tj@kernel.org>, Chunguang Xu <brookxu@tencent.com>
Subject: Re: [PATCH V3 4/8] block: don't check bio in blk_throtl_dispatch_work_fn
Date: Tue, 15 Feb 2022 00:11:55 -0800 [thread overview]
Message-ID: <YgtgS3aluiQtl/Aw@infradead.org> (raw)
In-Reply-To: <Ygtfyq7s0sx6vkJ8@T590>
On Tue, Feb 15, 2022 at 04:09:46PM +0800, Ming Lei wrote:
> The wrapper is for avoiding to add extra function call code in fast
> path since submit_bio_noacct_nocheck is global and can't be inlined.
It absolutle can be inlined if the compiler deems it worthwhile. But
givn that it is a trivial and cheap tail call is not worth it, so no
sensible compiler will do it and we should not force it into that
suboptimal decision.
next prev parent reply other threads:[~2022-02-15 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 3:30 [PATCH V3 0/8] block: improve iops limit throttle Ming Lei
2022-02-15 3:30 ` [PATCH V3 1/8] block: move submit_bio_checks() into submit_bio_noacct Ming Lei
2022-02-15 3:30 ` [PATCH V3 2/8] block: move blk_crypto_bio_prep() out of blk-mq.c Ming Lei
2022-02-15 3:30 ` [PATCH V3 3/8] block: don't declare submit_bio_checks in local header Ming Lei
2022-02-15 7:56 ` Christoph Hellwig
2022-02-15 3:30 ` [PATCH V3 4/8] block: don't check bio in blk_throtl_dispatch_work_fn Ming Lei
2022-02-15 7:57 ` Christoph Hellwig
2022-02-15 8:09 ` Ming Lei
2022-02-15 8:11 ` Christoph Hellwig [this message]
2022-02-15 3:30 ` [PATCH V3 5/8] block: merge submit_bio_checks() into submit_bio_noacct Ming Lei
2022-02-15 7:58 ` Christoph Hellwig
2022-02-15 3:30 ` [PATCH V3 6/8] block: throttle split bio in case of iops limit Ming Lei
2022-02-15 3:30 ` [PATCH V3 7/8] block: don't try to throttle split bio if iops limit isn't set Ming Lei
2022-02-15 3:30 ` [PATCH V3 8/8] block: revert 4f1e9630afe6 ("blk-throtl: optimize IOPS throttle for large IO scenarios") Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgtgS3aluiQtl/Aw@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brookxu@tencent.com \
--cc=lining2020x@163.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).