From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74AD9C433FE for ; Tue, 1 Mar 2022 04:11:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230348AbiCAEL5 (ORCPT ); Mon, 28 Feb 2022 23:11:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230243AbiCAEL4 (ORCPT ); Mon, 28 Feb 2022 23:11:56 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A425C5881D; Mon, 28 Feb 2022 20:11:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646107876; x=1677643876; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=qltwIc937Uu5ijgl7gEV8QkFm9r0IMF7rI6cefmccNg=; b=M6i/D8mcSzertUgoZedoD2ZstrLGCCTGRxA7uO6UBU7QgXeEd11RYcJs V6ee1QP1z99YCinMvfQDdQrE3XjHVBWIP5StE7FNhRTPyNgZoL34ltusE p8pMONrkYdSFzNcUXNVKSYb+kHTismkd+tQT6TYwEUl0537PIZu0YKfh0 mq9eAXB9AkQoXgqfJOq7mHmoh5tcXhGoz6tugCfr/W9WSm5OCKP20v3HS mXElobuZiJOsCZFz6bfn673RQ+uEIWWhPnIBNkcHHhtf91+0R0OcqPb67 EGpkMghHDT3nzGNy4KkydcReTvYd4HvD1a/mYFJZv/IFkUeihMA5V5D10 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="253242178" X-IronPort-AV: E=Sophos;i="5.90,144,1643702400"; d="scan'208";a="253242178" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 20:11:16 -0800 X-IronPort-AV: E=Sophos;i="5.90,144,1643702400"; d="scan'208";a="550543648" Received: from chunhanz-mobl.amr.corp.intel.com (HELO localhost) ([10.212.29.175]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 20:11:15 -0800 Date: Mon, 28 Feb 2022 20:11:15 -0800 From: Ira Weiny To: Christoph Hellwig Cc: Jens Axboe , Chris Zankel , Max Filippov , Justin Sanders , Philipp Reisner , Lars Ellenberg , Denis Efremov , Minchan Kim , Nitin Gupta , Coly Li , Dan Williams , Vishal Verma , linux-xtensa@linux-xtensa.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 10/10] floppy: use memcpy_{to,from}_bvec Message-ID: References: <20220222155156.597597-1-hch@lst.de> <20220222155156.597597-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220222155156.597597-11-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Feb 22, 2022 at 04:51:56PM +0100, Christoph Hellwig wrote: > Use the helpers instead of open coding them. > > Signed-off-by: Christoph Hellwig Reviewed-by: Ira Weiny > --- > drivers/block/floppy.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > index 19c2d0327e157..8c647532e3ce9 100644 > --- a/drivers/block/floppy.c > +++ b/drivers/block/floppy.c > @@ -2485,11 +2485,9 @@ static void copy_buffer(int ssize, int max_sector, int max_sector_2) > } > > if (CT(raw_cmd->cmd[COMMAND]) == FD_READ) > - memcpy_to_page(bv.bv_page, bv.bv_offset, dma_buffer, > - size); > + memcpy_to_bvec(&bv, dma_buffer); > else > - memcpy_from_page(dma_buffer, bv.bv_page, bv.bv_offset, > - size); > + memcpy_from_bvec(dma_buffer, &bv); > > remaining -= size; > dma_buffer += size; > -- > 2.30.2 > >