From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D432C433F5 for ; Wed, 2 Mar 2022 00:51:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238796AbiCBAwB (ORCPT ); Tue, 1 Mar 2022 19:52:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238783AbiCBAv7 (ORCPT ); Tue, 1 Mar 2022 19:51:59 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 908033F883 for ; Tue, 1 Mar 2022 16:51:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646182276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PSE7XhaCLoK3lvixPJtHiDdmfP+vYGOwXq3x81uSukw=; b=S8/dHvhyuZZknx1E1elAndcfnbHxjYDY5tT6wEHvCGU8SPo3GywmpmL3ASYsMKZDxe2rI6 F/wTad6+QJRhBhp5S2Q7QyyGdiUQJDuWEWKdLydoIQEsPipWI6M5RSlVj7ALcGqssEB3iI oBQymnLgTDmP/F8InIUnkc/6Y46OpwY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-BBzowO1OMtOEOJJbFaBeuw-1; Tue, 01 Mar 2022 19:51:11 -0500 X-MC-Unique: BBzowO1OMtOEOJJbFaBeuw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 051E08145F7; Wed, 2 Mar 2022 00:51:10 +0000 (UTC) Received: from T590 (ovpn-8-19.pek2.redhat.com [10.72.8.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C0B0519BE; Wed, 2 Mar 2022 00:51:04 +0000 (UTC) Date: Wed, 2 Mar 2022 08:51:00 +0800 From: Ming Lei To: "yukuai (C)" Cc: Christoph Hellwig , tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [PATCH v9] block: cancel all throttled bios in del_gendisk() Message-ID: References: <20220210115637.1074927-1-yukuai3@huawei.com> <836f0686-4ac8-327d-2bab-64a762ea8673@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <836f0686-4ac8-327d-2bab-64a762ea8673@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Mar 01, 2022 at 09:54:28PM +0800, yukuai (C) wrote: > 在 2022/03/01 18:29, Ming Lei 写道: > > On Mon, Feb 28, 2022 at 01:40:53AM -0800, Christoph Hellwig wrote: > > > On Mon, Feb 28, 2022 at 02:11:30PM +0800, Ming Lei wrote: > > > > > FYI, this crashed left rigt and center when running xfstests with > > > > > traces pointing to throtl_pending_timer_fn. > > > > > > > > Can you share the exact xfstests test(fs, test)? Or panic log? > > > > > > > > I can't reproduce it when running './check -g auto' on XFS, meantime > > > > tracking throtl_pending_timer_fn(). > > > > > > From a quick run using f2fs: > > > > > > generic/081 files ... [ 316.487861] run fstests generic/081 at 2022-02-28 09:38:40 > > > > Thanks for providing the reproducer. > > > > The reason is that the pending timer is deleted in blkg's release > > handler, so the timer can still be live after request queue is released. > > > > The patch of 'block: cancel all throttled bios in del_gendisk()' should just > > make it easier to trigger. > > > > After patch of "block: move blkcg initialization/destroy into disk allocation/ > > release handler" lands, the issue can be fixed easily by: > > Hi, > > Thanks for locating this problem, > > Perhaps this patch should wait for the problem to be solved. BTW, please see the top 3 patches in the following tree: https://github.com/ming1/linux/commits/my_v5.18-pre-rc xfstests generic/081 can run for hours without problems, without the fix, the crash can be triggered in 10 minutes. Thanks, Ming