Linux block layer
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Lukas Czerner <lczerner@redhat.com>,
	linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Olaf Fraczyk <olaf.fraczyk@gmail.com>,
	Karel Zak <kzak@redhat.com>,
	linux-block@vger.kernel.org
Subject: Re: blkdiscard BLKDISCARD ioctl failed: Remote I/O error
Date: Mon, 21 Feb 2022 22:45:01 +0800	[thread overview]
Message-ID: <YhOlbX0+0SxYl3Dq@T590> (raw)
In-Reply-To: <20220221130912.kboxxd2dga7edjkf@work>

On Mon, Feb 21, 2022 at 02:09:12PM +0100, Lukas Czerner wrote:
> Hi,
> 
> the problem is definitelly not in util-linux. In kernel there are checks
> in place that would prevent proceeding with out of range BLKDISCARD ioctl,
> but that's not what we hit here.
> 
> In the logs below you can see that the actual discard request failed,
> but it appears to be well within the device range. I don't know what is
> going on, maybe someone in the linux-block have a clue (adding to cc).
> 
> Meanwhile please let us know what kernel version do you have and provide
> a blkparse output of the blkdiscard run. You can do this for example
> 
> blktrace -a discard -d /dev/sdb -o - | \
> blkparse -o output -f "%D %2c %8s %5T.%9t %6p %2a %3d %10S + %10U (%4e) [%C]\n" -i -
> 
> then run the blkdiscard and see the content of output file.
> 
> Thanks!
> -Lukas
> 
> 
> 
> On Mon, Feb 21, 2022 at 01:34:57PM +0100, Olaf Fraczyk wrote:
> > Hello,
> > 
> > I had to put the disk in use, and I needed it in MBR format, so I can't
> > create GPT now.
> > 
> > Anyway, the reported size seems to be OK.
> > 
> > I have created 3rd partition to go till the end of the disk, as below:
> > 
> > Device     Boot      Start        End    Sectors   Size Id Type
> > /dev/sdb1             2048    4196351    4194304     2G fd Linux raid
> > autodetect
> > /dev/sdb2          4196352 1874855935 1870659584   892G fd Linux raid
> > autodetect
> > /dev/sdb3       1874855936 1875385007     529072 258.3M 83 Linux
> > 
> > I can fill it to the last sector using dd without problems:
> > 
> > [root@vh3 ~]# dd if=/dev/zero of=/dev/sdb3 bs=1024 count=264536
> > 264536+0 records in
> > 264536+0 records out
> > 270884864 bytes (271 MB, 258 MiB) copied, 4.81622 s, 56.2 MB/s
> > 
> > When I do blkdiscard:
> > 
> > root@vh3 ~]# blkdiscard -l 264536K /dev/sdb3
> > blkdiscard: /dev/sdb3: BLKDISCARD ioctl failed: Remote I/O error
> > [root@vh3 ~]# blkdiscard -l 264535K /dev/sdb3
> > [root@vh3 ~]#
> > 
> > In the /var/log/messages for the failed discard I get:
> > Feb 21 13:19:52 vh3 kernel: sd 1:0:1:0: [sdb] tag#2227 FAILED Result:
> > hostbyte=DID_OK driverbyte=DRIVER_SENSE cmd_age=0s
> > Feb 21 13:19:52 vh3 kernel: sd 1:0:1:0: [sdb] tag#2227 Sense Key : Illegal
> > Request [current]
> > Feb 21 13:19:52 vh3 kernel: sd 1:0:1:0: [sdb] tag#2227 Add. Sense: Logical
> > block address out of range
> > Feb 21 13:19:52 vh3 kernel: sd 1:0:1:0: [sdb] tag#2227 CDB: Unmap/Read
> > sub-channel 42 00 00 00 00 00 00 00 18 00
> > Feb 21 13:19:52 vh3 kernel: blk_update_request: critical target error, dev
> > sdb, sector 1874855936 op 0x3:(DISCARD) flags 0x800 phys_seg 1 prio class 0
> > 
> > I have the drive on a SAS controller - mpt3sas driver, LSI SAS2008

Looks one target issue, CC linux-scsi and mpt3sas guys.

> > > >
> > > > I tried to trim entire drive but I get the following error:
> > > > [root@vh3 util-linux-2.38-rc1]# ./blkdiscard /dev/sdb
> > > > lt-blkdiscard: /dev/sdb: BLKDISCARD ioctl failed: Remote I/O error
> > > >
> > > > I have done strace and I see:
> > > > ioctl(3, BLKGETSIZE64, [960197124096])  = 0
> > > > ioctl(3, BLKSSZGET, [512])              = 0
> > > > ioctl(3, BLKDISCARD, [0, 960197124096]) = -1 EREMOTEIO (Remote I/O error)
> > > >
> > > > When I do the same giving length explicitly I get the same error.
> > > >
> > > > However when I specify the length 512 bytes smaller, it works without a
> > > > problem:
> > > >
> > > > ioctl(3, BLKGETSIZE64, [960197124096])  = 0
> > > > ioctl(3, BLKSSZGET, [512])              = 0
> > > > ioctl(3, BLKDISCARD, [0, 960197123584]) = 0


Thanks,
Ming


  parent reply	other threads:[~2022-02-21 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAJWTG89dq0-HDb=hSJMdT5WyArH3dy+SKZNXDEr9WOWsaUsMEg@mail.gmail.com>
     [not found] ` <20220221090558.yvkgw2lujwjodhfi@ws.net.home>
     [not found]   ` <CAJWTG8-yrpLevVALX9ONnQGEgFcytYuhSk4ge_-qyi0tQS0keg@mail.gmail.com>
2022-02-21 13:09     ` blkdiscard BLKDISCARD ioctl failed: Remote I/O error Lukas Czerner
     [not found]       ` <CAJWTG89zxt3H41kaVjq9kSx=XSBwq=EpO9+1THydwG_-Xc6-ZQ@mail.gmail.com>
2022-02-21 13:47         ` Lukas Czerner
2022-02-21 14:45       ` Ming Lei [this message]
2022-02-21 15:50         ` Olaf Fraczyk
     [not found]         ` <CAJWTG8_2bgioHW87VntCvhCOA8_B8GMsuk+82o7uuHPx=9yt1w@mail.gmail.com>
2022-02-23  2:50           ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YhOlbX0+0SxYl3Dq@T590 \
    --to=ming.lei@redhat.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=kzak@redhat.com \
    --cc=lczerner@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=olaf.fraczyk@gmail.com \
    --cc=sathya.prakash@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox