linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Suwan Kim <suwan.kim027@gmail.com>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, pbonzini@redhat.com, stefanha@redhat.com,
	virtualization@lists.linux-foundation.org,
	linux-block@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: support polling I/O
Date: Mon, 14 Mar 2022 21:33:08 +0900	[thread overview]
Message-ID: <Yi82BL9KecQsVfgX@localhost.localdomain> (raw)
In-Reply-To: <ea838f63-5f63-6f3b-f49e-1107b43f7d1c@redhat.com>

On Mon, Mar 14, 2022 at 02:14:53PM +0800, Jason Wang wrote:
> 
> 在 2022/3/11 下午11:28, Suwan Kim 写道:
> > diff --git a/include/uapi/linux/virtio_blk.h b/include/uapi/linux/virtio_blk.h
> > index d888f013d9ff..3fcaf937afe1 100644
> > --- a/include/uapi/linux/virtio_blk.h
> > +++ b/include/uapi/linux/virtio_blk.h
> > @@ -119,8 +119,9 @@ struct virtio_blk_config {
> >   	 * deallocation of one or more of the sectors.
> >   	 */
> >   	__u8 write_zeroes_may_unmap;
> > +	__u8 unused1;
> > -	__u8 unused1[3];
> > +	__virtio16 num_poll_queues;
> >   } __attribute__((packed));
> 
> 
> This looks like a implementation specific (virtio-blk-pci) optimization, how
> about other implementation like vhost-user-blk?

I didn’t consider vhost-user-blk yet. But does vhost-user-blk also
use vritio_blk_config as kernel-qemu interface?

Does vhost-user-blk need additional modification to support polling
in kernel side?

Regards,
Suwan Kim

  reply	other threads:[~2022-03-14 12:42 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 15:28 [PATCH] virtio-blk: support polling I/O Suwan Kim
2022-03-11 15:38 ` Michael S. Tsirkin
2022-03-11 16:07   ` Suwan Kim
2022-03-11 16:18     ` Michael S. Tsirkin
2022-03-11 16:38       ` Suwan Kim
2022-03-13 10:37     ` Max Gurtovoy
2022-03-14  9:43       ` Suwan Kim
2022-03-14 10:25         ` Max Gurtovoy
2022-03-14 11:15           ` Michael S. Tsirkin
2022-03-14 13:22             ` Suwan Kim
2022-03-14 15:12               ` Michael S. Tsirkin
2022-03-14 13:26             ` Max Gurtovoy
2022-03-14 15:15               ` Michael S. Tsirkin
2022-03-14 16:33                 ` Max Gurtovoy
2022-03-14 22:22                   ` Michael S. Tsirkin
2022-03-13 10:42 ` Max Gurtovoy
2022-03-14  9:55   ` Suwan Kim
2022-03-14 10:32     ` Max Gurtovoy
2022-03-14  6:14 ` Jason Wang
2022-03-14 12:33   ` Suwan Kim [this message]
2022-03-14 14:48     ` Stefan Hajnoczi
     [not found]     ` <CACGkMEujXYNE-88=m9ohjbeAj2F7CqEUes8gOUmasTNtwn2bUA@mail.gmail.com>
2022-03-15 14:43       ` Suwan Kim
2022-03-15 14:53         ` Michael S. Tsirkin
2022-03-16  2:02         ` Jason Wang
2022-03-16 11:25           ` Max Gurtovoy
2022-03-16 13:32           ` Suwan Kim
2022-03-16 15:32           ` Suwan Kim
2022-03-16 15:36             ` Max Gurtovoy
2022-03-16 16:00               ` Stefan Hajnoczi
2022-03-17  2:20             ` Jason Wang
2022-03-17 15:03               ` Suwan Kim
2022-03-14 15:19 ` Stefan Hajnoczi
2022-03-15 13:55   ` Suwan Kim
2022-03-16 12:20     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yi82BL9KecQsVfgX@localhost.localdomain \
    --to=suwan.kim027@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).