From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EC0BC433F5 for ; Sun, 6 Mar 2022 03:41:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231775AbiCFDmW (ORCPT ); Sat, 5 Mar 2022 22:42:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbiCFDmV (ORCPT ); Sat, 5 Mar 2022 22:42:21 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 375142AE12 for ; Sat, 5 Mar 2022 19:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646538088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XXlGSXVmynJV+V8oFLfC1k+jVEqFHszdBNk7MqMn16I=; b=JWIPrTSAZPXZiCT5rkx+Z2ptmhMBh8EOylYjSI+wd8kgGzLNecIwiiE1DErfC55UJkf2bn yntacvWWTVTDWHgxpUl8iG3rJ64EkxsiW7Yfl9n+ECzpBfORMSzJn5IDrA0FJAMZrbBnqK Z1TPRkUrz8yC44f9QhQBNvmun+506yY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-15-esWYfbCmPYiRbFk23JLU7g-1; Sat, 05 Mar 2022 22:41:27 -0500 X-MC-Unique: esWYfbCmPYiRbFk23JLU7g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2B0881800D50; Sun, 6 Mar 2022 03:41:26 +0000 (UTC) Received: from T590 (ovpn-8-17.pek2.redhat.com [10.72.8.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 427FA6A4B7; Sun, 6 Mar 2022 03:41:10 +0000 (UTC) Date: Sun, 6 Mar 2022 11:41:05 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , "Martin K. Petersen" , Bart Van Assche , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 06/14] sd: delay calling free_opal_dev Message-ID: References: <20220304160331.399757-1-hch@lst.de> <20220304160331.399757-7-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220304160331.399757-7-hch@lst.de> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Fri, Mar 04, 2022 at 05:03:23PM +0100, Christoph Hellwig wrote: > Call free_opal_dev from scsi_disk_release as the opal_dev field is access > from the ioctl handler, which isn't synchronized vs sd_release and thus > can be accesses during or after sd_release was called. > > Signed-off-by: Christoph Hellwig Reviewed-by: Ming Lei -- Ming