From: Christoph Hellwig <hch@infradead.org>
To: Valentin Kleibel <valentin@vrvis.at>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Justin Sanders <justin@coraid.com>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: aoe: handle device timeouts atomic-safe
Date: Thu, 10 Mar 2022 07:29:44 -0800 [thread overview]
Message-ID: <YioZaO21yingv0nD@infradead.org> (raw)
In-Reply-To: <07bafc71-a6d2-ad6d-4706-7c99047b3228@vrvis.at>
On Thu, Mar 10, 2022 at 04:17:37PM +0100, Valentin Kleibel wrote:
> If an aoe device does not respond to any packet on the network layer within
> aoe_deadsecs, the driver tries to mark the device as down, fail all I/O and
> clean out the queue.
I think the problem is that aoe even tries to queue up request
internally. It really needs to switch to use BLK_MQ_F_BLOCKING and
stop queuing up the requests internall at all.
next prev parent reply other threads:[~2022-03-10 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 15:17 [PATCH] block: aoe: handle device timeouts atomic-safe Valentin Kleibel
2022-03-10 15:29 ` Christoph Hellwig [this message]
2022-03-28 15:06 ` Valentin Kleibel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YioZaO21yingv0nD@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=justin@coraid.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentin@vrvis.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).