From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CB1FC433FE for ; Mon, 21 Mar 2022 14:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349557AbiCUOfd (ORCPT ); Mon, 21 Mar 2022 10:35:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349560AbiCUOe7 (ORCPT ); Mon, 21 Mar 2022 10:34:59 -0400 Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79BA15F4C3 for ; Mon, 21 Mar 2022 07:33:22 -0700 (PDT) Received: by mail-qv1-xf2f.google.com with SMTP id k7so6090461qvc.4 for ; Mon, 21 Mar 2022 07:33:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=us46s+4EPzPx/x4i+BKRoQL7SxJrfbc5izH2Jmo2exM=; b=DIuqnBQJ+D8uHwQ7rRY5uyiULjBVtGxEIduobDz0t0FBX5mpZcJsO2XEa7VcfdYkTV Id4JSNKheF4QVSr29xg2y4dpXKa+mNZ2kUnP5A3CPEDMxNUr4EWymy9l4Vn/3RxTAMbI 5lTmrOiCAUkcw9k+dUBjP1pCVh5tgyhxuqknjM25vCB2aVtaav/IDcqyxrW7OWFOMHT8 bYMlSIU0PtnhAcyoLIXRIBv0xnx6zpiWOJNkCu5n+1hFtDdOBF6/ex9VAFmP3vHQTLif pbOlH6lxjYZilIi5w3jrbWEPu0N5CQvdlTVbazta9mjupWBYWjNxrn9mm96PMVaICDk7 iucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=us46s+4EPzPx/x4i+BKRoQL7SxJrfbc5izH2Jmo2exM=; b=yVRjW7gd1KKEDwn/OY1kHfW5AmiI8CenB+2NdJ1vhdR0GcTjb7DOMH2t24RV1I/Qmp IVoNBU2uqi0gMTwlDXS+jofmg1m4ZJx8BT76M4ahH3Bfrl2Ulp+WY7JVt1iPgOK0rOHl gt8ogbhrnYVF8cOihkBvIvMJFnv7uj2N6S04GfaXld+3j+PCWcJ0tJAATSRLdrr2xCKo SQ5B2Mto1I7ORii2qWAL9RzlYQDkPYboEJKdTxYfLv8imqN2st/1FYyMp3VaZZFTcXiJ KglPNiyZSBUcf2VrezuzGEuqwQGkO4X+ISsXYnNghAc6Io22gSuOIgrmR0QFwn28TuiM KNRg== X-Gm-Message-State: AOAM531J3oXTyXs9vCPB9Qg0sL3AkSVh2RV9cXwuPHq1tJ/pIl4GQocP vDNV07SgYXYfNF5U1cLjdVWJ4Q== X-Google-Smtp-Source: ABdhPJzuIjrelcElq9DwcPDy1CDAqt1nawinhreHQoL5wDrjqG6A6BI3rtIwaguRYBMUW2VDRm2ACA== X-Received: by 2002:ad4:5f8e:0:b0:441:3dbf:15d5 with SMTP id jp14-20020ad45f8e000000b004413dbf15d5mr801181qvb.108.1647873202008; Mon, 21 Mar 2022 07:33:22 -0700 (PDT) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id j11-20020a05622a038b00b002e1f0bc2e8csm9636047qtx.81.2022.03.21.07.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 07:33:21 -0700 (PDT) Date: Mon, 21 Mar 2022 10:33:20 -0400 From: Johannes Weiner To: cgel.zte@gmail.com Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, Yang Yang , Ran Xiaokai Subject: Re: [PATCH] block/psi: make PSI annotations of submit_bio only work for file pages Message-ID: References: <20220316063927.2128383-1-yang.yang29@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220316063927.2128383-1-yang.yang29@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Mar 16, 2022 at 06:39:28AM +0000, cgel.zte@gmail.com wrote: > From: Yang Yang > > psi tracks the time spent on submitting the IO of refaulting file pages > and anonymous pages[1]. But after we tracks refaulting anonymous pages > in swap_readpage[2][3], there is no need to track refaulting anonymous > pages in submit_bio. > > So this patch can reduce redundant calling of psi_memstall_enter. And > make it easier to track refaulting file pages and anonymous pages > separately. I don't think this is an improvement. psi_memstall_enter() will check current->in_memstall once, detect the nested call, and bail. Your patch checks PageSwapBacked for every page being added. It's more branches for less robust code.