From: Ming Lei <ming.lei@redhat.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH 3/8] dm: pass 'dm_io' instance to dm_io_acct directly
Date: Wed, 13 Apr 2022 09:43:08 +0800 [thread overview]
Message-ID: <YlYqrC41lzT5c4gm@T590> (raw)
In-Reply-To: <YlXhC1tHYYyCQxdI@redhat.com>
On Tue, Apr 12, 2022 at 04:28:59PM -0400, Mike Snitzer wrote:
> On Tue, Apr 12 2022 at 4:56P -0400,
> Ming Lei <ming.lei@redhat.com> wrote:
>
> > All the other 4 parameters are retrieved from the 'dm_io' instance, so
> > not necessary to pass all four to dm_io_acct().
> >
> > Signed-off-by: Ming Lei <ming.lei@redhat.com>
>
> Yeah, commit 0ab30b4079e103 ("dm: eliminate copying of dm_io fields in
> dm_io_dec_pending") could've gone further to do what you've done here
> in this patch.
>
> But it stopped short because of the additional "games" associated with
> the late assignment of io->orig_bio that is in the dm-5.19 branch.
OK, I will rebase on dm-5.19, but IMO the idea of late assignment of
io->orig_bio isn't good, same with splitting one bio just for
accounting, things shouldn't be so tricky.
Thanks,
Ming
next prev parent reply other threads:[~2022-04-13 1:43 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 8:56 [PATCH 0/8] dm: io accounting & polling improvement Ming Lei
2022-04-12 8:56 ` [PATCH 1/8] block: replace disk based account with bdev's Ming Lei
2022-04-16 5:57 ` Christoph Hellwig
2022-04-12 8:56 ` [PATCH 2/8] dm: don't pass bio to __dm_start_io_acct and dm_end_io_acct Ming Lei
2022-04-12 8:56 ` [PATCH 3/8] dm: pass 'dm_io' instance to dm_io_acct directly Ming Lei
2022-04-12 20:28 ` Mike Snitzer
2022-04-13 1:43 ` Ming Lei [this message]
2022-04-12 8:56 ` [PATCH 4/8] dm: switch to bdev based io accounting interface Ming Lei
2022-04-12 8:56 ` [PATCH 5/8] dm: always setup ->orig_bio in alloc_io Ming Lei
2022-04-12 20:52 ` Mike Snitzer
2022-04-12 22:38 ` Damien Le Moal
2022-04-12 23:00 ` Mike Snitzer
2022-04-12 23:31 ` Damien Le Moal
2022-04-13 0:00 ` Damien Le Moal
2022-04-13 1:56 ` Ming Lei
2022-04-13 6:12 ` Mike Snitzer
2022-04-13 12:26 ` Ming Lei
2022-04-13 17:58 ` Mike Snitzer
2022-04-14 0:36 ` Ming Lei
2022-04-14 2:25 ` Mike Snitzer
2022-04-14 3:57 ` Ming Lei
2022-04-14 17:45 ` Mike Snitzer
2022-04-15 0:14 ` Ming Lei
2022-04-15 21:06 ` Mike Snitzer
2022-04-17 2:22 ` Ming Lei
2022-04-12 8:56 ` [PATCH 6/8] dm: don't grab target io reference in dm_zone_map_bio Ming Lei
2022-04-12 8:56 ` [PATCH 7/8] dm: improve target io referencing Ming Lei
2022-04-12 8:56 ` [PATCH 8/8] dm: put all polled io into one single list Ming Lei
2022-04-12 17:15 ` [PATCH 0/8] dm: io accounting & polling improvement Mike Snitzer
2022-04-16 5:58 ` Christoph Hellwig
2022-04-17 1:23 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlYqrC41lzT5c4gm@T590 \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox