Re: [PATCH 1/8] block: replace disk based account with bdev's

Christoph Hellwig
2022-04-16T05:57:41Z

On Tue, Apr 12, 2022 at 04:56:09PM +0800, Ming Lei wrote:
> 'block device' is generic type for interface, and gendisk becomes more
> one block layer internal type, so replace disk based account interface
> with bdec's.

I can't parse this sentence.

> +unsigned long bdev_start_io_acct(struct block_device *bdev,
> + unsigned int sectors, unsigned int op,
> + unsigned long start_time)
> {
> - return __part_start_io_acct(disk->part0, sectors, op, jiffies);
> + return __part_start_io_acct(bdev, sectors, op, start_time);
> }
> -EXPORT_SYMBOL(disk_start_io_acct);
> +EXPORT_SYMBOL(bdev_start_io_acct);

Just rename __part_start_io_acct to bdev_start_io_acct instead.

> -void disk_end_io_acct(struct gendisk *disk, unsigned int op,
> +void bdev_end_io_acct(struct block_device *bdev, unsigned int op,
> unsigned long start_time)
> {
> - __part_end_io_acct(disk->part0, op, start_time);
> + __part_end_io_acct(bdev, op, start_time);
> }
> -EXPORT_SYMBOL(disk_end_io_acct);
> +EXPORT_SYMBOL(bdev_end_io_acct);

Same here.