From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8B70C433F5 for ; Thu, 28 Apr 2022 23:32:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353284AbiD1XfX (ORCPT ); Thu, 28 Apr 2022 19:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351584AbiD1XfX (ORCPT ); Thu, 28 Apr 2022 19:35:23 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B70F8021A for ; Thu, 28 Apr 2022 16:32:07 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id 129so3777356wmz.0 for ; Thu, 28 Apr 2022 16:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=U18JmttrWXC+dMo65uq1AVze/9tijl7gVBdfgYMLOyc=; b=dX9s//oHOCgopIuh3/A/jI+WEXOGKTKLEl1fzmJAb9QtU1665WwAQNu/TnAhm50dnd SZeauD6KXsQ1PXfV705MgU640OoFev6np8mR5Z8sPGZ1APl3djuoXdw460r937n2mjqo pIFTa7dVYqZ2+92z9GRM+6J7S003TEFajVvD3HT7Ms755YkKGGAQGXEKXFcIug1kceLs vqpGjUQztPBzJX42bsMmDQbckFmMr1ptJOdf6ceQpDx9PoGERjx9o8adaHEamHR06mNX PRVDPwEC9kKpXxc79wjKG3h+PNmS28HpyHsF8jbi29NxoNpwSPrITsPRdQefUqSU7lm+ 4vrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=U18JmttrWXC+dMo65uq1AVze/9tijl7gVBdfgYMLOyc=; b=PX51d7hrQDS/YcvILg8fM6NAkqn7FGHlWdvF36YH3CmKQamD/N3JO6vtJGjouzV5sg oiw5mHFQ+YU0qM2KiX7PjtwYZBuESmJJtdDQuHjzbw/QH+Uk1H46RM2473SEoirthzDd 0rScGZKqpTtpr6kvpWga94dCQhslavmcrYsvwmSsOX0sUVMU9yFZsGgusFnQ6zRlEGYc eAyxugK7XhoQTv8tD+MiYzvVn1Sr6j7vplpodg2iN3YpeCb7TqrJAh2JTD/gPQW51sV7 F3+IT154Igl0a5xvtXu91L2ZjmVwvX4PyrtQNMdbeImVPQIdPtVCuqODTsT6AjrIgs57 SLtg== X-Gm-Message-State: AOAM532LzH7u/QkLeD0bCm8BBjseRmsa527hrL4mkdPhqlSL/aZ7sYFX FkI0XSd4rSzrOPEaDdapkk7JYQ== X-Google-Smtp-Source: ABdhPJzeLS0evOGxFcyadWvNaI6tE7OR9+Bv6XXsfNEOqOFDlQEkwhUCDFe5/ZOEPsY0FtRHk0uWXQ== X-Received: by 2002:a05:600c:4f54:b0:392:9267:7930 with SMTP id m20-20020a05600c4f5400b0039292677930mr488739wmq.63.1651188725615; Thu, 28 Apr 2022 16:32:05 -0700 (PDT) Received: from equinox (2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.a.1.e.e.d.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:dfde:e1a0::2]) by smtp.gmail.com with ESMTPSA id g20-20020a7bc4d4000000b003941f18086dsm95913wmk.30.2022.04.28.16.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Apr 2022 16:32:05 -0700 (PDT) Date: Fri, 29 Apr 2022 00:32:03 +0100 From: Phillip Potter To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org Subject: Re: [PATCH 2/3] cdrom: mark CDROMGETSPINDOWN/CDROMSETSPINDOWN obsolete Message-ID: References: <20220427132436.12795-1-paul.gortmaker@windriver.com> <20220427132436.12795-3-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427132436.12795-3-paul.gortmaker@windriver.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Apr 27, 2022 at 09:24:34AM -0400, Paul Gortmaker wrote: > These were only implemented by the IDE CD driver, which has since > been removed. Given that nobody is likely to create new CD/DVD > hardware (and associated drivers) we can mark these appropriately. > > Cc: Jens Axboe > Cc: Christoph Hellwig > Cc: Phillip Potter > Signed-off-by: Paul Gortmaker > --- > Documentation/userspace-api/ioctl/cdrom.rst | 6 ++++++ > include/uapi/linux/cdrom.h | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/userspace-api/ioctl/cdrom.rst b/Documentation/userspace-api/ioctl/cdrom.rst > index 682948fc88a3..2ad91dbebd7c 100644 > --- a/Documentation/userspace-api/ioctl/cdrom.rst > +++ b/Documentation/userspace-api/ioctl/cdrom.rst > @@ -718,6 +718,9 @@ CDROMPLAYBLK > > > CDROMGETSPINDOWN > + Obsolete, was ide-cd only > + > + > usage:: > > char spindown; > @@ -736,6 +739,9 @@ CDROMGETSPINDOWN > > > CDROMSETSPINDOWN > + Obsolete, was ide-cd only > + > + > usage:: > > char spindown > diff --git a/include/uapi/linux/cdrom.h b/include/uapi/linux/cdrom.h > index 804ff8d98f71..011e594e4a0d 100644 > --- a/include/uapi/linux/cdrom.h > +++ b/include/uapi/linux/cdrom.h > @@ -103,7 +103,7 @@ > #define CDROMREADALL 0x5318 /* read all 2646 bytes */ > > /* > - * These ioctls are (now) only in ide-cd.c for controlling > + * These ioctls were only in (now removed) ide-cd.c for controlling > * drive spindown time. They should be implemented in the > * Uniform driver, via generic packet commands, GPCMD_MODE_SELECT_10, > * GPCMD_MODE_SENSE_10 and the GPMODE_POWER_PAGE... > -- > 2.33.0 > Same for this one, looks good, will send on. Many thanks. Signed-off-by: Phillip Potter Regards, Phil