From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45E09C433F5 for ; Tue, 3 May 2022 21:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242956AbiECVjp (ORCPT ); Tue, 3 May 2022 17:39:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiECVjp (ORCPT ); Tue, 3 May 2022 17:39:45 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57CBA3134F; Tue, 3 May 2022 14:36:11 -0700 (PDT) Received: from penguin.thunk.org (cn-8-34-116-185.paclightwave.com [8.34.116.185] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 243La4c4019236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 3 May 2022 17:36:06 -0400 Received: by penguin.thunk.org (Postfix, from userid 1000) id ECB33446C7; Tue, 3 May 2022 14:35:59 -0700 (PDT) Date: Tue, 3 May 2022 14:35:59 -0700 From: tytso To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-spdx@vger.kernel.org Subject: Re: SPDX tag and top of file comment cleanups for the loop driver Message-ID: References: <20220419063303.583106-1-hch@lst.de> <20220503201334.GA7325@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503201334.GA7325@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, May 03, 2022 at 10:13:34PM +0200, Christoph Hellwig wrote: > On Tue, May 03, 2022 at 04:06:28PM -0400, Theodore Ts'o wrote: > > > Ted, does the SPDX tag match your original licensing decision back then, > > > or do we need to correct it? Does the auto-converted tag on the loop.h > > > SPDX header (GPL1.0 or later with syscall exception) make sense, or > > > should that have been GPL2 only with syscall exception? > > > > I think you've removed the loop.h in the patch series, so it shouldn't > > matter what the tag would be for loop.h, right? In any case, GPLv2 > > only was certainly the intent at the time. > > Well, there were two loop.h files - drivers/block/loop.h gets removed > in this series, but include/uapi/linux/loop.h stays. Ah, thanks for the clarification. Yes, GPLv2 with the syscall extension is what would be appropriate for include/uapi/linux/loop.h. - Ted