From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@fb.com>
Cc: linux-block@vger.kernel.org, axboe@kernel.dk,
Kernel Team <kernel-team@fb.com>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 1/3] block: export dma_alignment attribute
Date: Sun, 15 May 2022 23:52:46 -0700 [thread overview]
Message-ID: <YoH0vuUA4KdcpEAz@infradead.org> (raw)
In-Reply-To: <20220513161339.1580042-1-kbusch@fb.com>
I'm not against the sysfs file, but for applications this is a
horrible interface. We really need something that works on the fd.
The XFS_IOC_DIOINFO ioctl from xfs is one, although ugly, option.
The other is to export the alignment requirements through statx.
We had that whole discussion with the inline crypto direct I/O support,
and we really need to tackle it rather sooner than later.
next prev parent reply other threads:[~2022-05-16 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 16:13 [PATCH 1/3] block: export dma_alignment attribute Keith Busch
2022-05-13 16:13 ` [PATCH 2/3] block: relax direct io memory alignment Keith Busch
2022-05-13 16:13 ` [PATCH 3/3] block: ensure direct io is a block size Keith Busch
2022-05-14 2:26 ` Bart Van Assche
2022-05-16 10:13 ` Damien Le Moal
2022-05-16 14:01 ` Keith Busch
2022-05-16 6:52 ` Christoph Hellwig [this message]
2022-05-16 14:32 ` [PATCH 1/3] block: export dma_alignment attribute Keith Busch
2022-05-17 22:55 ` Keith Busch
2022-05-18 7:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoH0vuUA4KdcpEAz@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox