From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F924C433EF for ; Mon, 16 May 2022 06:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240450AbiEPGwt (ORCPT ); Mon, 16 May 2022 02:52:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236988AbiEPGwt (ORCPT ); Mon, 16 May 2022 02:52:49 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BCD0C22 for ; Sun, 15 May 2022 23:52:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BozS1yjgE2A7/eDPeLlRtEvpubSE7mKnF2BVs+qKp64=; b=yg2NrU40d7XYgdUg3c4+5eQrAx 1NkQmklRr9VUTHhlP+rN4aUACVnqvjbzp66ln1XreUKmFppM3ly9Lij2UwbiDKYALRnZh3lloBxeX Xg367wXEVq9mBlZZCgRoQwKNFJDnpG3Ts/SaPBsbtI+yNGzoQIMjyVI8zrEXei8iiurfS7ikA8p8I 1KdE++tptS1NNgS0UKBcH6PpYW3xWRr9adi/4RZdBtEjBuRQD/x81nKQOKI+6441fzoWEuFEhox9L +jP6/vllh4QfvO5eslztPl/juvmfOZcU41b8W9hpEJLI56x36upFEZdfJ+h2qEiXQtMiY78p6EGIu EBCouM/w==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqUb1-006GMw-0F; Mon, 16 May 2022 06:52:47 +0000 Date: Sun, 15 May 2022 23:52:46 -0700 From: Christoph Hellwig To: Keith Busch Cc: linux-block@vger.kernel.org, axboe@kernel.dk, Kernel Team , Keith Busch Subject: Re: [PATCH 1/3] block: export dma_alignment attribute Message-ID: References: <20220513161339.1580042-1-kbusch@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220513161339.1580042-1-kbusch@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org I'm not against the sysfs file, but for applications this is a horrible interface. We really need something that works on the fd. The XFS_IOC_DIOINFO ioctl from xfs is one, although ugly, option. The other is to export the alignment requirements through statx. We had that whole discussion with the inline crypto direct I/O support, and we really need to tackle it rather sooner than later.