From: Eric Biggers <ebiggers@kernel.org>
To: Keith Busch <kbusch@kernel.org>
Cc: Keith Busch <kbusch@fb.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
axboe@kernel.dk, Kernel Team <Kernel-team@fb.com>,
hch@lst.de, bvanassche@acm.org, damien.lemoal@opensource.wdc.com
Subject: Re: [PATCHv2 3/3] block: relax direct io memory alignment
Date: Thu, 19 May 2022 10:27:04 -0700 [thread overview]
Message-ID: <YoZ96LBMOiNwFhRZ@sol.localdomain> (raw)
In-Reply-To: <YoZ30XROoiFleT16@kbusch-mbp.dhcp.thefacebook.com>
On Thu, May 19, 2022 at 11:01:05AM -0600, Keith Busch wrote:
> On Wed, May 18, 2022 at 10:56:04PM -0600, Keith Busch wrote:
> > On Wed, May 18, 2022 at 08:27:31PM -0700, Eric Biggers wrote:
> > > Note, there's also lots of code that assumes that bio_vec::bv_len is a multiple
> > > of 512.
> >
> > Could you point me to some examples?
>
> Just to answer my own question, blk-crypto and blk-merge appear to have these
> 512 byte bv_len assumptions.
blk_bio_segment_split() and bio_advance_iter() are two more examples.
- Eric
next prev parent reply other threads:[~2022-05-19 17:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 17:11 [PATCHv2 0/3] direct io alignment relax Keith Busch
2022-05-18 17:11 ` [PATCHv2 1/3] block/bio: remove duplicate append pages code Keith Busch
2022-05-18 20:21 ` Chaitanya Kulkarni
2022-05-19 4:28 ` Bart Van Assche
2022-05-19 7:32 ` Christoph Hellwig
2022-05-19 14:19 ` Keith Busch
2022-05-18 17:11 ` [PATCHv2 2/3] block: export dma_alignment attribute Keith Busch
2022-05-18 20:22 ` Chaitanya Kulkarni
2022-05-19 4:30 ` Bart Van Assche
2022-05-19 7:33 ` Christoph Hellwig
2022-05-18 17:11 ` [PATCHv2 3/3] block: relax direct io memory alignment Keith Busch
2022-05-19 0:14 ` Eric Biggers
2022-05-19 1:00 ` Keith Busch
2022-05-19 1:53 ` Eric Biggers
2022-05-19 1:59 ` Keith Busch
2022-05-19 2:08 ` Eric Biggers
2022-05-19 2:25 ` Keith Busch
2022-05-19 3:27 ` Eric Biggers
2022-05-19 4:40 ` Bart Van Assche
2022-05-19 4:56 ` Keith Busch
2022-05-19 6:45 ` Damien Le Moal
2022-05-19 17:19 ` Eric Biggers
2022-05-20 3:41 ` Damien Le Moal
2022-05-19 7:41 ` Christoph Hellwig
2022-05-19 16:35 ` Keith Busch
2022-05-20 6:07 ` Christoph Hellwig
2022-05-19 17:01 ` Keith Busch
2022-05-19 17:27 ` Eric Biggers [this message]
2022-05-19 17:43 ` Keith Busch
2022-05-19 7:39 ` Christoph Hellwig
2022-05-19 22:31 ` Keith Busch
2022-05-19 7:38 ` Christoph Hellwig
2022-05-19 14:08 ` Keith Busch
2022-05-20 6:10 ` Christoph Hellwig
2022-05-18 22:45 ` [PATCHv2 0/3] direct io alignment relax Jens Axboe
2022-05-19 7:42 ` Christoph Hellwig
2022-05-19 12:46 ` Jens Axboe
2022-05-18 23:26 ` Eric Biggers
2022-05-19 0:51 ` Keith Busch
2022-05-19 1:02 ` Chaitanya Kulkarni
2022-05-19 2:02 ` Eric Biggers
2022-05-19 7:43 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoZ96LBMOiNwFhRZ@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=Kernel-team@fb.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox