From: Greg KH <gregkh@linuxfoundation.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: paolo.valente@linaro.org, axboe@kernel.dk,
xieyongji@bytedance.com, ming.lei@redhat.com,
linux-block@vger.kernel.org,
Oleksandr Natalenko <oleksandr@natalenko.name>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: return ELEVATOR_DISCARD_MERGE if possible
Date: Mon, 23 May 2022 17:13:19 +0200 [thread overview]
Message-ID: <Youkj8RWDNlpNUnL@kroah.com> (raw)
In-Reply-To: <20220521185626.3333530-1-gwendal@chromium.org>
On Sat, May 21, 2022 at 11:56:26AM -0700, Gwendal Grignou wrote:
> From: Ming Lei <ming.lei@redhat.com>
>
> When merging one bio to request, if they are discard IO and the queue
> supports multi-range discard, we need to return ELEVATOR_DISCARD_MERGE
> because both block core and related drivers(nvme, virtio-blk) doesn't
> handle mixed discard io merge(traditional IO merge together with
> discard merge) well.
>
> Fix the issue by returning ELEVATOR_DISCARD_MERGE in this situation,
> so both blk-mq and drivers just need to handle multi-range discard.
>
> Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> Fixes: 2705dfb20947 ("block: fix discard request merge")
> Link: https://lore.kernel.org/r/20210729034226.1591070-1-ming.lei@redhat.com
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> commit 866663b7b52d2 upstream.
>
> Similar to commit 87aa69aa10b42 ("block: return ELEVATOR_DISCARD_MERGE if possible")
> in 5.10 kernel.
>
> Conflicts:
> block/blk-merge.c: function at a different place.
> block/mq-deadline-main.c: not in 5.4, use mq-deadline.c instead.
>
> Cc: <stable@vger.kernel.org> # 5.4.y
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Now queued up, thanks.
greg k-h
next prev parent reply other threads:[~2022-05-23 15:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 18:56 [PATCH] block: return ELEVATOR_DISCARD_MERGE if possible Gwendal Grignou
2022-05-23 15:13 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-07-29 3:42 Ming Lei
2021-07-29 7:17 ` Oleksandr Natalenko
2021-07-29 9:18 ` Ming Lei
2021-08-05 3:35 ` Ming Lei
2021-08-09 20:30 ` Oleksandr Natalenko
2021-08-09 20:36 ` Jens Axboe
2021-08-10 2:47 ` Ming Lei
2021-08-10 2:55 ` Jens Axboe
2021-08-10 3:28 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Youkj8RWDNlpNUnL@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=gwendal@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=paolo.valente@linaro.org \
--cc=stable@vger.kernel.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).