Re: [PATCH] block: remove per-disk debugfs files in blk_unregister_queue

Christoph Hellwig
2022-05-24T12:00:16Z

On Tue, May 24, 2022 at 11:29:05AM +0200, Hannes Reinecke wrote:
> Calling debugfs_remove_recursive(q->debugfs_dir) for all queue types, but
> setting q->debugfs_dir to NULL only for mq?
> Care to explain?

->debugfs_dir is never set to NULL, only q->sched_debugfs_dir and
q->rqos_debugfs_dir. Both of those are only used for blk-mq (and
don't really need the reset either, but this is all existing code
and will be dealt with later instead of a minimalistic bug fix.