From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646FFC433EF for ; Thu, 2 Jun 2022 20:39:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239280AbiFBUjk (ORCPT ); Thu, 2 Jun 2022 16:39:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239284AbiFBUj3 (ORCPT ); Thu, 2 Jun 2022 16:39:29 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E4BE1FCDE; Thu, 2 Jun 2022 13:39:19 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id gd1so5906222pjb.2; Thu, 02 Jun 2022 13:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NYkACjksTq7D5aqYKY+rKmNd5ashkIfCvgLNEkSUbY4=; b=VOoyvWVAcqaU05NT1mJw6gqT2XZyQl9VZosdCL3rWV7Sfb31CIedlhghvwKlyCTlgM 4EmYtZsp0oDGXH7Sfq9OUYqx6T57oS/fqxkS6XU+BF9VG8iMEagWxwaCBeV59dwks9Ne +sxGEJ/V+morFEZXMOgoH98Qnf5I3+3Konysn2VkKRxS8dwpQN7ZIORUzMQmYcIcn/mO fHc7VZN2++Hb/wqYaHVxLILDutZdZurupx6x2KAVR1NzmA/9ttj5Ao0OePBo66dbNrpW B6sbZXTu632SvtkE+Y9GLIw2dJcS8mZ9L9eOGSedtmCMHTljAxs32Md+vZk2pkQZlFLS S/zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=NYkACjksTq7D5aqYKY+rKmNd5ashkIfCvgLNEkSUbY4=; b=ixSNDwue02pvkZnfE4blIZO4XGIuqwDeOVkZA9ps8bpIRXpE4muzipdHKLZw0334M1 J8iNiJ+UTptJbju//R0aWg13a0z7hwTAb+nRQHmNK7xVlXxUItwyu8nUG57/ps3jqH19 n06LjiInXPw62x+3KocmSo8uUnsZ7Kk8T/yUDeDXzOtF2v7zTfqAUdKxKOdB3JD3gayo 0kA4Zl34enNBzvYmQhDHm50MrzFHGpmlcW+AJ+qg/g3hmtj905m9c3kq9ca56budd+aI 201UOn3hUkrTQzeNWRx6BFoh6YA/Qe4I3K3ybHPQYQvuD1gW6LQINdCIkBx/6QHKdGVT 9g9Q== X-Gm-Message-State: AOAM532X6PSxvUv5jigD5EtC4zmLTzmO/q4xsH+2glv67oG9Y8c0J2BZ QdJO04yXUceMP3ZifvmwRwk= X-Google-Smtp-Source: ABdhPJwCauiVmlbZVrmjHvh14oNg3atOmWAenuo+u7mo7KfDoP3F/8vvEv+MM5EaVGAijl7adpq+6g== X-Received: by 2002:a17:90a:9505:b0:1df:2162:2bb5 with SMTP id t5-20020a17090a950500b001df21622bb5mr42153874pjo.73.1654202358802; Thu, 02 Jun 2022 13:39:18 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:49ff]) by smtp.gmail.com with ESMTPSA id p16-20020a1709027ed000b0016403cae7desm3209918plb.276.2022.06.02.13.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 13:39:18 -0700 (PDT) Sender: Tejun Heo Date: Thu, 2 Jun 2022 10:39:16 -1000 From: Tejun Heo To: Waiman Long Cc: Jens Axboe , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ming Lei Subject: Re: [PATCH v6 2/3] blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path Message-ID: References: <20220602192020.166940-1-longman@redhat.com> <20220602192020.166940-3-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220602192020.166940-3-longman@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, Jun 02, 2022 at 03:20:19PM -0400, Waiman Long wrote: > For blkcg_css_alloc(), the only error that will be returned is -ENOMEM. > Simplify error handling code by returning this error directly instead > of setting an intermediate "ret" variable. > > Signed-off-by: Waiman Long Acked-by: Tejun Heo Thanks. -- tejun