Re: [PATCH] block: fix rq_qos leak for bio based queue

[Ming Lei <ming.lei@redhat.com>]

On Tue, Jun 14, 2022 at 12:12:03AM -0700, Christoph Hellwig wrote:
> On Tue, Jun 14, 2022 at 02:44:26PM +0800, Ming Lei wrote:
> > Commit 5ca7546fe317 ("block: move rq_qos_exit() into disk_release()")
> > moves rq_qos_exit() to disk_release(), but only done for blk-mq queue.
> > 
> > However, now rq qos can be created via blkcg_init_queue() for bio based
> > queue, so we need to call rq_qos_exit() for bio queue too.
> > 
> > In theory, so far, rq_qos is only implemented for request based queue,
> > and we should only add it for blk-mq queue. However, if using blk-mq
> > during allocating queue may not be known, fix the rq qos leak issue by
> > always releasing rq qos for both two kinds of queues.
> 
> This is also fixed by "block: disable the elevator int del_gendisk"
> which was just resent yesterday, and fundamentally gets the lifetimes
> right rather than doctoring around even more.
 
Just checked my block mbox and lore, not see the patch sent from
yesterday.

Thanks, 
Ming