From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
Niklas Cassel <Niklas.Cassel@wdc.com>
Subject: Re: [PATCH 9/9] block: Always initialize bio IO priority on submit
Date: Thu, 23 Jun 2022 07:01:56 -0700 [thread overview]
Message-ID: <YrRyVJV3OR/qYHsD@infradead.org> (raw)
In-Reply-To: <20220623074840.5960-9-jack@suse.cz>
On Thu, Jun 23, 2022 at 09:48:34AM +0200, Jan Kara wrote:
> Currently, IO priority set in task's IO context is not reflected in the
> bio->bi_ioprio for most IO (only io_uring and direct IO set it). This
> results in odd results where process is submitting some bios with one
> priority and other bios with a different (unset) priority and due to
> differing priorities bios cannot be merged. Make sure bio->bi_ioprio is
> always set on bio submission.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2022-06-23 14:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 7:48 [PATCH 0/9 v5] block: Fix IO priority mess Jan Kara
2022-06-23 7:48 ` [PATCH 1/9] block: fix default IO priority handling again Jan Kara
2022-06-23 13:57 ` Christoph Hellwig
2022-06-23 14:23 ` Jens Axboe
2022-06-23 7:48 ` [PATCH 2/9] block: Return effective IO priority from get_current_ioprio() Jan Kara
2022-06-23 13:57 ` Christoph Hellwig
2022-06-23 7:48 ` [PATCH 3/9] block: Generalize get_current_ioprio() for any task Jan Kara
2022-06-23 13:59 ` Christoph Hellwig
2022-06-23 7:48 ` [PATCH 4/9] block: Make ioprio_best() static Jan Kara
2022-06-23 13:58 ` Christoph Hellwig
2022-06-23 7:48 ` [PATCH 5/9] block: Fix handling of tasks without ioprio in ioprio_get(2) Jan Kara
2022-06-23 7:48 ` [PATCH 6/9] blk-ioprio: Remove unneeded field Jan Kara
2022-06-23 14:00 ` Christoph Hellwig
2022-06-23 7:48 ` [PATCH 7/9] blk-ioprio: Convert from rqos policy to direct call Jan Kara
2022-06-23 14:01 ` Christoph Hellwig
2022-06-23 7:48 ` [PATCH 8/9] block: Initialize bio priority earlier Jan Kara
2022-06-23 14:01 ` Christoph Hellwig
2022-06-23 7:48 ` [PATCH 9/9] block: Always initialize bio IO priority on submit Jan Kara
2022-06-23 14:01 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-21 10:24 [PATCH 0/9 v4] block: Fix IO priority mess Jan Kara
2022-06-21 10:24 ` [PATCH 9/9] block: Always initialize bio IO priority on submit Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrRyVJV3OR/qYHsD@infradead.org \
--to=hch@infradead.org \
--cc=Niklas.Cassel@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).