From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D1C5C43334 for ; Mon, 25 Jul 2022 07:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229694AbiGYHK2 (ORCPT ); Mon, 25 Jul 2022 03:10:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230240AbiGYHK0 (ORCPT ); Mon, 25 Jul 2022 03:10:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F40229FED for ; Mon, 25 Jul 2022 00:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658733024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=onlISrKOwpltqPX+flGP9VcruRUveSxQFVBOAG0Sxg4=; b=YFgFcchj5OEDnyauQiUlRr+AOVBjy02aLwoqebxIOqsYYyeEHMVa8cgQnBcJ41tIm7qRqB qgbCGVmUwPr3v1X1oDKtX42D1QtPV//2hBTcJQSrh0qNAgMBldiVadnj5QOtBlWlf7Nxms rYELSYTz4BoKua+ZddydG8WBZXTzbGg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-392-SJr4wvRTOhOsiCtNcVg42Q-1; Mon, 25 Jul 2022 03:10:23 -0400 X-MC-Unique: SJr4wvRTOhOsiCtNcVg42Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DA7B585A588; Mon, 25 Jul 2022 07:10:22 +0000 (UTC) Received: from T590 (ovpn-8-29.pek2.redhat.com [10.72.8.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8E771121314; Mon, 25 Jul 2022 07:10:19 +0000 (UTC) Date: Mon, 25 Jul 2022 15:10:14 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, ZiyangZhang Subject: Re: [PATCH 0/2] ublk_drv: add generic mechanism to get/set parameters Message-ID: References: <20220723150713.750369-1-ming.lei@redhat.com> <20220725064716.GC20796@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220725064716.GC20796@lst.de> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jul 25, 2022 at 08:47:16AM +0200, Christoph Hellwig wrote: > While we're at it, can we clean up how the logical block size, > device size and max transfer size are set? > > I think we can drop setting all of them from the ADD_DEV ioctl, > as none of them is needed. start_dev then just sets the device > size, and everything else goes through the SET_PARAM ioctl? Yeah, that is exactly the plan to cleanup all, including removing block_size, dev_blocks and rq_max_blocks from ublksrv_ctrl_dev_info. Thanks, Ming