linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, ming.lei@redhat.com
Subject: Re: [PATCH 2/2] Revert "ublk_drv: fix request queue leak"
Date: Tue, 19 Jul 2022 20:37:23 +0800	[thread overview]
Message-ID: <YtalgzqC/q3JpYCR@T590> (raw)
In-Reply-To: <20220718062928.335399-2-hch@lst.de>

Hi Christoph,

On Mon, Jul 18, 2022 at 08:29:28AM +0200, Christoph Hellwig wrote:
> This was just a rather broken way to paper over a core block layer bug
> that is now fixed.
> 
> This reverts commit cebbe577cb17ed9b04b50d9e6802a8bacffbadca.

This change will break START_DEV/STOP_DEV, which is supposed to run
multiple cycles after the device is added, especially this way can
help to implement error recovery from userside, such as one ubq_daemon
is crashed/hang, the device can be recovered by sending STOP_DEV/START_DEV
commands again after new ubq_daemon is setup.

So here we do need separated request_queue/disk, and the model is
similar with scsi's, in which disk rebind needs to be supported
and GD_OWNS_QUEUE can't be set.


Thanks,
Ming


  reply	other threads:[~2022-07-19 13:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18  6:29 [PATCH 1/2] block: call blk_mq_exit_queue from disk_release for never added disks Christoph Hellwig
2022-07-18  6:29 ` [PATCH 2/2] Revert "ublk_drv: fix request queue leak" Christoph Hellwig
2022-07-19 12:37   ` Ming Lei [this message]
2022-07-20  6:07     ` Christoph Hellwig
2022-07-20  7:47       ` Ming Lei
2022-07-20  9:00         ` Christoph Hellwig
2022-07-20 10:16           ` Ming Lei
2022-07-20 10:23           ` Ming Lei
2022-07-20 13:08             ` Christoph Hellwig
2022-07-20 15:33               ` Ming Lei
2022-07-21  5:12                 ` Christoph Hellwig
2022-07-18  7:18 ` [PATCH 1/2] block: call blk_mq_exit_queue from disk_release for never added disks Ming Lei
2022-07-18  8:33   ` Ming Lei
2022-07-18 13:08     ` Christoph Hellwig
2022-07-18 13:07   ` Christoph Hellwig
2022-07-18 15:16     ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtalgzqC/q3JpYCR@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).