Linux block layer
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Liu Song <liusong@linux.alibaba.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	axboe@kernel.dk, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: avoid potential infinite loop in __blk_mq_alloc_request
Date: Fri, 22 Jul 2022 09:08:02 -0700	[thread overview]
Message-ID: <YtrLYiJFlqL64voT@infradead.org> (raw)
In-Reply-To: <eb99b420-3e28-98c7-dacc-767d564661e2@linux.alibaba.com>

On Fri, Jul 22, 2022 at 04:15:49PM +0800, Liu Song wrote:
> It is a reasonable approach to prevent abnormal alloc from going down,
> but this is a very rare exception after all, and above modification is
> checked
> every alloc request, which seems to be a bit excessive overhead.

Every allocation of a passthrough requests.  Which isn't really the
normal fast path.

  reply	other threads:[~2022-07-22 16:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-22  5:22 [PATCH] blk-mq: avoid potential infinite loop in __blk_mq_alloc_request Liu Song
2022-07-22  5:33 ` Christoph Hellwig
2022-07-22  8:15   ` Liu Song
2022-07-22 16:08     ` Christoph Hellwig [this message]
2022-08-09 10:10       ` Liu Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtrLYiJFlqL64voT@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liusong@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox