From: Tejun Heo <tj@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: mkoutny@suse.com, axboe@kernel.dk, ming.lei@redhat.com,
cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yukuai3@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH RESEND v6 8/8] blk-throttle: clean up flag 'THROTL_TG_PENDING'
Date: Wed, 27 Jul 2022 08:44:29 -1000 [thread overview]
Message-ID: <YuGHjf9MWjirOWcm@slm.duckdns.org> (raw)
In-Reply-To: <20220701093441.885741-9-yukuai1@huaweicloud.com>
On Fri, Jul 01, 2022 at 05:34:41PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> All related operations are inside 'queue_lock', there is no need to use
> the flag, we only need to make sure throtl_enqueue_tg() is called when
> the first bio is throttled, and throtl_dequeue_tg() is called when the
> last throttled bio is dispatched.
Ah, okay, so the prev patch was to enable this cleanup. Can you please note
so in the previous patch and also that this doesn't cause any functional
changes?
Thanks.
--
tejun
next prev parent reply other threads:[~2022-07-27 19:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 9:34 [PATCH RESEND v6 0/8] bugfix and cleanup for blk-throttle Yu Kuai
2022-07-01 9:34 ` [PATCH RESEND v6 1/8] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-07-27 18:27 ` Tejun Heo
2022-07-29 6:32 ` Yu Kuai
2022-07-29 18:04 ` Tejun Heo
2022-07-30 1:06 ` Yu Kuai
2022-07-01 9:34 ` [PATCH RESEND v6 2/8] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-07-27 18:28 ` Tejun Heo
2022-07-28 10:23 ` Yu Kuai
2022-07-01 9:34 ` [PATCH RESEND v6 3/8] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-07-01 9:34 ` [PATCH RESEND v6 4/8] blk-throttle: fix io hung due to config updates Yu Kuai
2022-07-27 18:39 ` Tejun Heo
2022-07-28 9:33 ` Michal Koutný
2022-07-28 10:34 ` Yu Kuai
2022-07-28 16:55 ` Tejun Heo
2022-07-01 9:34 ` [PATCH RESEND v6 5/8] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai
2022-07-27 18:39 ` Tejun Heo
2022-07-01 9:34 ` [PATCH RESEND v6 6/8] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai
2022-07-27 18:40 ` Tejun Heo
2022-07-01 9:34 ` [PATCH RESEND v6 7/8] blk-throttle: cleanup tg_update_disptime() Yu Kuai
2022-07-27 18:42 ` Tejun Heo
2022-07-01 9:34 ` [PATCH RESEND v6 8/8] blk-throttle: clean up flag 'THROTL_TG_PENDING' Yu Kuai
2022-07-27 18:44 ` Tejun Heo [this message]
2022-07-28 11:03 ` Yu Kuai
2022-07-10 2:39 ` [PATCH RESEND v6 0/8] bugfix and cleanup for blk-throttle Yu Kuai
2022-07-10 2:40 ` Yu Kuai
2022-07-20 11:45 ` Yu Kuai
2022-07-27 12:12 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuGHjf9MWjirOWcm@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mkoutny@suse.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).