From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org,
ZiyangZhang <ZiyangZhang@linux.alibaba.com>
Subject: Re: [PATCH V3 5/5] ublk_drv: cleanup ublksrv_ctrl_dev_info
Date: Fri, 29 Jul 2022 23:02:03 +0800 [thread overview]
Message-ID: <YuP2a8EzUEAi4S5m@T590> (raw)
In-Reply-To: <20220729142431.GE32321@lst.de>
On Fri, Jul 29, 2022 at 04:24:31PM +0200, Christoph Hellwig wrote:
> On Fri, Jul 29, 2022 at 03:29:54PM +0800, Ming Lei wrote:
> > Remove all block device related info from ublksrv_ctrl_dev_info,
> > meantime reduce its size into 64 bytes because:
> >
> > 1) ublksrv_ctrl_dev_info becomes cleaner without including any
> > block related info
> >
> > 2) generic set/get parameter command can be used to set block
> > related setting easily and cleanly
> >
> > 3) generic set/get parameter command can be used for extending
> > ublk without needing more info in ublksrv_ctrl_dev_info
>
> This should condense the structure instead of spreading random
> reserveѕ.
>
> One more reason why we should not just merge half-baked UAPIs before
> a few good rounds of review :(
This patch does depend on set/get parameter(s) command.
Thanks,
Ming
prev parent reply other threads:[~2022-07-29 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 7:29 [PATCH V3 0/5] ublk_drv: add generic mechanism to get/set parameters Ming Lei
2022-07-29 7:29 ` [PATCH V3 1/5] ublk_drv: cancel device even though disk isn't up Ming Lei
2022-07-29 14:19 ` Christoph Hellwig
2022-07-29 7:29 ` [PATCH V3 2/5] ublk_drv: fix ublk device leak in case that add_disk fails Ming Lei
2022-07-29 14:20 ` Christoph Hellwig
2022-07-29 7:29 ` [PATCH V3 3/5] ublk_drv: add SET_PARAM/GET_PARAM control command Ming Lei
2022-07-29 14:22 ` Christoph Hellwig
2022-07-29 14:59 ` Ming Lei
2022-07-29 7:29 ` [PATCH V3 4/5] ublk_drv: add two parameter types Ming Lei
2022-07-29 14:23 ` Christoph Hellwig
2022-07-29 7:29 ` [PATCH V3 5/5] ublk_drv: cleanup ublksrv_ctrl_dev_info Ming Lei
2022-07-29 14:24 ` Christoph Hellwig
2022-07-29 15:02 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuP2a8EzUEAi4S5m@T590 \
--to=ming.lei@redhat.com \
--cc=ZiyangZhang@linux.alibaba.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).