From: Christoph Hellwig <hch@infradead.org>
To: gjoyce@linux.vnet.ibm.com
Cc: linux-block@vger.kernel.org, keyrings@vger.kernel.org,
dhowells@redhat.com, jarkko@kernel.org,
jonathan.derrick@linux.dev, brking@linux.vnet.ibm.com,
gjoyce@ibm.com, nayna@linux.ibm.com
Subject: Re: [PATCH 3/3] block: sed-opal: keyring support for SED Opal keys
Date: Fri, 29 Jul 2022 07:28:14 -0700 [thread overview]
Message-ID: <YuPufn3sh99hd/r3@infradead.org> (raw)
In-Reply-To: <20220727181422.3504563-4-gjoyce@linux.vnet.ibm.com>
Looks good from the block layer POV, although my understanding of the
keyring is so limited to be useless:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2022-07-29 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 18:14 [PATCH 0/3] sed-opal: keyrings, discovery, revert and key store gjoyce
2022-07-27 18:14 ` [PATCH 1/3] block: sed-opal: Implement IOC_OPAL_DISCOVERY gjoyce
2022-07-29 14:27 ` Christoph Hellwig
2022-07-27 18:14 ` [PATCH 2/3] block: sed-opal: Implement IOC_OPAL_REVERT_LSP gjoyce
2022-07-29 14:27 ` Christoph Hellwig
2022-07-27 18:14 ` [PATCH 3/3] block: sed-opal: keyring support for SED Opal keys gjoyce
2022-07-29 14:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuPufn3sh99hd/r3@infradead.org \
--to=hch@infradead.org \
--cc=brking@linux.vnet.ibm.com \
--cc=dhowells@redhat.com \
--cc=gjoyce@ibm.com \
--cc=gjoyce@linux.vnet.ibm.com \
--cc=jarkko@kernel.org \
--cc=jonathan.derrick@linux.dev \
--cc=keyrings@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=nayna@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).