From: Tejun Heo <tj@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com
Subject: Re: [PATCH 3/4] blk-throttle: cleanup tg_update_disptime()
Date: Tue, 23 Aug 2022 08:29:47 -1000 [thread overview]
Message-ID: <YwUcm4CimyyOFlP9@slm.duckdns.org> (raw)
In-Reply-To: <20220823013810.406075-4-yukuai1@huaweicloud.com>
On Tue, Aug 23, 2022 at 09:38:09AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> tg_update_disptime() only need to adjust postion for 'tg' in
> 'parent_sq', there is no need to call throtl_enqueue/dequeue_tg(),
> since they will set/clear flag THROTL_TG_PENDING and increase/decrease
> nr_pending, which is useless. By the way, clear the flag/decrease
> nr_pending while there are still throttled bios is not good for debugging.
>
> There are no functional changes.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2022-08-23 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 1:38 [PATCH 0/4] blk-throttle cleanups Yu Kuai
2022-08-23 1:38 ` [PATCH 1/4] blk-throttle: use 'READ/WRITE' instead of '0/1' Yu Kuai
2022-08-23 1:38 ` [PATCH 2/4] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs Yu Kuai
2022-08-23 1:38 ` [PATCH 3/4] blk-throttle: cleanup tg_update_disptime() Yu Kuai
2022-08-23 18:29 ` Tejun Heo [this message]
2022-08-23 1:38 ` [PATCH 4/4] blk-throttle: cleanup throtl_dequeue_tg() Yu Kuai
2022-08-23 18:34 ` Tejun Heo
2022-08-24 1:19 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwUcm4CimyyOFlP9@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox