public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, ming.lei@redhat.com, mkoutny@suse.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, yi.zhang@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v8 1/4] blk-throttle: fix that io throttle can only work for single bio
Date: Thu, 25 Aug 2022 08:15:47 -1000	[thread overview]
Message-ID: <Ywe8Uz4Gy6j/EsUg@slm.duckdns.org> (raw)
In-Reply-To: <73c72914-e27d-b261-e040-2dd31e8a6b9f@huaweicloud.com>

On Wed, Aug 24, 2022 at 09:15:32AM +0800, Yu Kuai wrote:
> This patch actually set two flags when bio is throttled and
> dispatched, and only iops flag is cleared after the original bio is
> split. If only one flag can be used, the way that I come up with is
> that let iops limit become default, which means bio is always counted
> for iops limit each time blk_throtl_bio() is called. I'm not quite
> sure yet if iops limit can be counted excessively this way in some
> special scenario...

I don't think we have a path where we clone and re-submit other than
splitting. What do you think about renaming the flag to BIO_BPS_THROTTLED
and just assuming that IOPS is always applied?

Thanks.

-- 
tejun

  reply	other threads:[~2022-08-25 18:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-23  3:31 [PATCH v8 0/4] blk-throttle bugfix Yu Kuai
2022-08-23  3:31 ` [PATCH v8 1/4] blk-throttle: fix that io throttle can only work for single bio Yu Kuai
2022-08-23 18:07   ` Tejun Heo
2022-08-24  1:15     ` Yu Kuai
2022-08-25 18:15       ` Tejun Heo [this message]
2022-08-26  1:07         ` Yu Kuai
2022-08-23  3:31 ` [PATCH v8 2/4] blk-throttle: prevent overflow while calculating wait time Yu Kuai
2022-08-23  3:31 ` [PATCH v8 3/4] blk-throttle: factor out code to calculate ios/bytes_allowed Yu Kuai
2022-08-23  3:31 ` [PATCH v8 4/4] blk-throttle: fix io hung due to configuration updates Yu Kuai
2022-08-23  9:41   ` Michal Koutný
2022-08-23 18:08   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ywe8Uz4Gy6j/EsUg@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox