linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Pankaj Raghav <p.raghav@samsung.com>
Cc: agk@redhat.com, snitzer@kernel.org, axboe@kernel.dk,
	damien.lemoal@opensource.wdc.com, hch@lst.de,
	pankydev8@gmail.com, Johannes.Thumshirn@wdc.com,
	linux-block@vger.kernel.org, dm-devel@redhat.com, hare@suse.de,
	jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
	matias.bjorling@wdc.com, gost.dev@samsung.com,
	bvanassche@acm.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH v12 12/13] dm: introduce DM_EMULATED_ZONES target type
Date: Thu, 1 Sep 2022 20:28:59 -0400	[thread overview]
Message-ID: <YxFOS8fq8AeE5mkf@redhat.com> (raw)
In-Reply-To: <20220823121859.163903-13-p.raghav@samsung.com>

On Tue, Aug 23 2022 at  8:18P -0400,
Pankaj Raghav <p.raghav@samsung.com> wrote:

> Introduce a new target type DM_EMULATED_ZONES for targets with
> a different number of sectors per zone (aka zone size) than the underlying
> device zone size.
> 
> This target type is introduced as the existing zoned targets assume
> that the target and the underlying device have the same zone size.
> The new target: dm-po2zone will use this new target
> type as it emulates the zone boundary that is different from the
> underlying zoned device.
> 
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

This patch's use of "target type" jargon isn't valid. 

Please say "target feature flag" and rename DM_EMULATED_ZONES to
DM_TARGET_EMULATED_ZONES in the subject and header.

But, with those fixed:

Signed-off-by: Mike Snitzer <snitzer@kernel.org>

(fyi, I'll review patch 13, the dm-po2zone target, tomorrow)


  reply	other threads:[~2022-09-02  0:29 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220823121901eucas1p1d8ec2e0d3d6be63b9d4338f70dd717fe@eucas1p1.samsung.com>
2022-08-23 12:18 ` [PATCH v12 00/13] support zoned block devices with non-power-of-2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220823121902eucas1p21176f8fff1a4f928bee6e03141cdf69a@eucas1p2.samsung.com>
2022-08-23 12:18     ` [PATCH v12 01/13] block: make bdev_nr_zones and disk_zone_no generic for npo2 zone size Pankaj Raghav
     [not found]   ` <CGME20220823121903eucas1p230518b312d5260d28e356ba911a27469@eucas1p2.samsung.com>
2022-08-23 12:18     ` [PATCH v12 02/13] block:rearrange bdev_{is_zoned,zone_sectors,get_queue} helpers in blkdev.h Pankaj Raghav
2022-08-25 21:45       ` Bart Van Assche
     [not found]   ` <CGME20220823121904eucas1p1cdedb3e9af928e25564f46e70765d39b@eucas1p1.samsung.com>
2022-08-23 12:18     ` [PATCH v12 03/13] block: allow blk-zoned devices to have non-power-of-2 zone size Pankaj Raghav
2022-08-26 20:06       ` Jonathan Derrick
2022-08-26 20:09         ` Jonathan Derrick
     [not found]   ` <CGME20220823121905eucas1p14db498525742a606137e098b3cb8f70b@eucas1p1.samsung.com>
2022-08-23 12:18     ` [PATCH v12 04/13] nvmet: Allow ZNS target to support non-power_of_2 zone sizes Pankaj Raghav
     [not found]   ` <CGME20220823121907eucas1p295c375935b556729864dce39534c2579@eucas1p2.samsung.com>
2022-08-23 12:18     ` [PATCH v12 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size Pankaj Raghav
2022-08-25 21:46       ` Bart Van Assche
     [not found]   ` <CGME20220823121907eucas1p27664a441113cb557af8fce3ef2800e34@eucas1p2.samsung.com>
2022-08-23 12:18     ` [PATCH v12 06/13] null_blk: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-25 21:49       ` Bart Van Assche
     [not found]   ` <CGME20220823121909eucas1p16b613217afcb29c29d6149c2620c93b4@eucas1p1.samsung.com>
2022-08-23 12:18     ` [PATCH v12 07/13] zonefs: allow non power of 2 zoned devices Pankaj Raghav
     [not found]   ` <CGME20220823121909eucas1p113c0c29f7e28d0ee3e1161f7da243baf@eucas1p1.samsung.com>
2022-08-23 12:18     ` [PATCH v12 08/13] dm-zoned: ensure only power of 2 zone sizes are allowed Pankaj Raghav
2022-08-25 21:50       ` [dm-devel] " Bart Van Assche
2022-09-02  0:16       ` Mike Snitzer
     [not found]   ` <CGME20220823121911eucas1p2a55dec72a6d780123e6c7655aee72457@eucas1p2.samsung.com>
2022-08-23 12:18     ` [PATCH v12 09/13] dm-zone: use generic helpers to calculate offset from zone start Pankaj Raghav
2022-08-25 21:53       ` Bart Van Assche
2022-09-02  0:16       ` Mike Snitzer
     [not found]   ` <CGME20220823121912eucas1p18223e1b04b65a8a10f6c50187e7474ea@eucas1p1.samsung.com>
2022-08-23 12:18     ` [PATCH v12 10/13] dm-table: allow zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-09-02  0:17       ` Mike Snitzer
     [not found]   ` <CGME20220823121913eucas1p11c222f4c57a0132117bb9712e6018668@eucas1p1.samsung.com>
2022-08-23 12:18     ` [PATCH v12 11/13] dm: call dm_zone_endio after the target endio callback for zoned devices Pankaj Raghav
2022-09-02  0:18       ` Mike Snitzer
     [not found]   ` <CGME20220823121914eucas1p2f4445066c23cdae4fca80f7b0268815b@eucas1p2.samsung.com>
2022-08-23 12:18     ` [PATCH v12 12/13] dm: introduce DM_EMULATED_ZONES target type Pankaj Raghav
2022-09-02  0:28       ` Mike Snitzer [this message]
2022-09-02 12:02         ` Pankaj Raghav
2022-09-02 18:43           ` Mike Snitzer
     [not found]   ` <CGME20220823121915eucas1p10296d6a2ab00de5e73791a7d6b8e39de@eucas1p1.samsung.com>
2022-08-23 12:18     ` [PATCH v12 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes Pankaj Raghav
2022-08-30  2:52       ` Shinichiro Kawasaki
2022-08-30 10:03         ` Pankaj Raghav
2022-09-02 12:05       ` Pankaj Raghav
2022-09-02 20:55       ` Mike Snitzer
2022-09-02 21:07         ` Mike Snitzer
2022-09-05 12:57           ` Pankaj Raghav
2022-09-05 12:48         ` Pankaj Raghav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YxFOS8fq8AeE5mkf@redhat.com \
    --to=snitzer@redhat.com \
    --cc=Johannes.Thumshirn@wdc.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=dm-devel@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=matias.bjorling@wdc.com \
    --cc=p.raghav@samsung.com \
    --cc=pankydev8@gmail.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).