Re: [PATCH 16/17] btrfs: split zone append bios in btrfs_submit_bio

Johannes Thumshirn
2022-09-05T13:15:39Z

On 01.09.22 09:43, Christoph Hellwig wrote:
> - if (btrfs_dev_is_sequential(dev, physical)) {
> - u64 zone_start = round_down(physical,
> - dev->fs_info->zone_size);
> -
> - bio->bi_iter.bi_sector = zone_start >> SECTOR_SHIFT;
> - } else {
> - bio->bi_opf &= ~REQ_OP_ZONE_APPEND;
> - bio->bi_opf |= REQ_OP_WRITE;
> - }
> + ASSERT(btrfs_dev_is_sequential(dev, physical));
> + bio->bi_iter.bi_sector = zone_start >> SECTOR_SHIFT;

That ASSERT() will trigger on conventional zones, won't it?