Re: consolidate btrfs checksumming, repair and bio splitting

Steven Rostedt
2022-11-02T04:00:33Z

On Mon, 31 Oct 2022 13:19:12 +0100
David Sterba <dsterba@suse.cz> wrote:

> > The policy is simple. If someone requires a copyright notice for their
> > code, you simply add it, or do not take their code. You can be specific
> > about what that code is that is copyrighted. Perhaps just around the code in
> > question or a description at the top.
>
> Let's say it's OK for substantial amount of code. What if somebody
> moves existing code that he did not write to a new file and adds a
> copyright notice? We got stuck there, both sides have different answer.
> I see it at minimum as unfair to the original code authors if not
> completely wrong because it could appear as "stealing" ownership.

Add the commit shas to the copyright, which will explicitly show the
actual code involved. As it's been pointed out in other places, the git
commits itself does not actually state who the copyright owner is.

>
> > Looking over the thread, I'm still confused at what the issue is. Is it
> > that if you add one copyright notice you must do it for everyone else? Is
> > everyone else asking for it? If not, just add the one and be done with it.
>
> My motivation is to be fair to all contributors and stick to the project
> standards (ideally defined in process). Adding a copyright notice after
> several years of not taking them would rightfully raise questions from
> past and current contributors what would deserve to be mentioned as
> copyright holders.

As I stated: "If someone requires a copyright notice for their code,
you simply add it, or do not take their code."

No one is forcing you to add the copyright. You have an alternative.
Don't take the code. If your subsystem's policy is that of not adding
copyright notices, then the submitters should honor it. I see Christoph
as being OK for not accepting his code because of this policy.

Just like I will not submit to projects that require me to hand over my
copyright. It's their right to have that policy. It's my right not to
submit code to them. Or if I do submit, refuse to conform to their
policy, and have my code rejected because of it.

It really comes down to how badly do you want Christoph's code?

-- Steve