Re: regression caused by block: freeze the queue earlier in del_gendisk

Greg KH
2022-09-26T07:10:30Z

On Wed, Sep 21, 2022 at 08:56:53AM -0600, Jens Axboe wrote:
> On Wed, Sep 21, 2022 at 8:47 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Sep 21, 2022 at 08:34:26AM -0600, Jens Axboe wrote:
> > > On 9/21/22 3:25 AM, Thorsten Leemhuis wrote:
> > > > On 20.09.22 16:14, Jens Axboe wrote:
> > > >> On 9/20/22 8:12 AM, Christoph Hellwig wrote:
> > > >>> On Tue, Sep 20, 2022 at 08:05:06AM -0600, Jens Axboe wrote:
> > > >>>> Christoph and I discussed this one last week, and he has a plan to try
> > > >>>> a flag approach. Christoph, did you get a chance to bang that out? Would
> > > >>>> be nice to get this one wrapped up.
> > > >>>
> > > >>> I gave up on that as it will be far too much change so late in
> > > >>> the cycle and sent you the revert yesterday.
> > > >>
> > > >> Gotcha, haven't made it all the way through the emails of the morning yet.
> > > >> I'll queue it up.
> > > >
> > > > Thx to both of you for taking care of this.
> > > >
> > > > Nitpicking: that patch is missing a "CC: stable@..." tag to ensure
> > > > automatic and quick backporting to 5.19.y. Or is the block layer among
> > > > the subsystems that prefer to handle such things manually?
> > > >
> > > > Ohh, and a fixes tag might have been good as well; a "Link:" tag
> > > > pointing to the report, too. If either would have been there, regzbot
> > > > would have noticed Christoph's patch posting and I wouldn't have
> > > > bothered you yesterday. :-) But whatever, not that important.
> > >
> > > We'll just have to ensure we ping stable on it when it goes in.
> >
> > If you have a git id that is not going to change, I can watch out for it
> > to land in Linus's tree...
>
> This is the one:
>
> commit 4c66a326b5ab784cddd72de07ac5b6210e9e1b06 (origin/block-6.0, block-6.0)
> Author: Christoph Hellwig <hch@lst.de>
> Date: Mon Sep 19 16:40:49 2022 +0200
>
> Revert "block: freeze the queue earlier in del_gendisk"
>
> Thanks Greg!

Now queued up, thanks.

greg k-h