From: Keith Busch <kbusch@kernel.org>
To: Keith Busch <kbusch@fb.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org
Subject: Re: [PATCHv4] sbitmap: fix batched wait_cnt accounting
Date: Fri, 9 Sep 2022 09:18:21 -0600 [thread overview]
Message-ID: <YxtZPUk2NepSneeE@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220908215132.3243008-1-kbusch@fb.com>
On Thu, Sep 08, 2022 at 02:51:32PM -0700, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> Batched completions can clear multiple bits, but we're only decrementing
> the wait_cnt by one each time. This can cause waiters to never be woken,
> stalling IO. Use the batched count instead.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215679
A longer running test finally failed in a similar manner as before. It use to
fail much quicker, but something is still off, so please don't apply or test
this patch yet.
next prev parent reply other threads:[~2022-09-09 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 21:51 [PATCHv4] sbitmap: fix batched wait_cnt accounting Keith Busch
2022-09-09 15:18 ` Keith Busch [this message]
2022-09-09 15:49 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxtZPUk2NepSneeE@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=kbusch@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox