Re: [PATCH v2 4/7] iov_iter: new iov_iter_pin_pages*() routines

John Hubbard
2022-09-06T07:59:16Z

On 9/6/22 00:48, Christoph Hellwig wrote:
> On Tue, Sep 06, 2022 at 12:44:28AM -0700, John Hubbard wrote:
>> OK, that part is clear.
>>
>>> - for the pin case don't use the existing bvec helper at all, but
>>> copy the logic for the block layer for not pinning.
>>
>> I'm almost, but not quite sure I get the idea above. Overall, what
>> happens to bvec pages? Leave the get_page() pin in place for FOLL_GET
>> (or USE_FOLL_GET), I suppose, but do...what, for FOLL_PIN callers?
>
> Do not change anyhing for FOLL_GET callers, as they are on the way out
> anyway.
>

OK, got it.

> For FOLL_PIN callers, never pin bvec and kvec pages: For file systems
> not acquiring a reference is obviously safe, and the other callers will
> need an audit, but I can't think of why it woul ever be unsafe.

In order to do that, one would need to be confident that such bvec and kvec
pages do not get passed down to bio_release_pages() (or the new
bio_unpin_pages()). Also, I'm missing a key point, because today bvec pages get
a get_page() reference from __iov_iter_get_pages_alloc(). If I just skip
that, then the get/put calls are unbalanced...

I can just hear Al Viro repeating his points about splice() and vmsplice(),
heh. :)

thanks,

--
John Hubbard
NVIDIA