From: Ming Lei <ming.lei@redhat.com>
To: John Garry <john.g.garry@oracle.com>
Cc: "Ming Lei" <tom.leiming@gmail.com>,
"Jens Axboe" <axboe@kernel.dk>,
linux-block@vger.kernel.org,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] block: mark GFP_NOIO around sysfs ->store()
Date: Mon, 13 Jan 2025 16:29:37 +0800 [thread overview]
Message-ID: <Z4TO8bVgTnB2q4Oz@fedora> (raw)
In-Reply-To: <2fa89c60-a507-43a0-98ed-4d182bcea3ee@oracle.com>
On Mon, Jan 13, 2025 at 08:23:19AM +0000, John Garry wrote:
> On 13/01/2025 01:58, Ming Lei wrote:
> > sysfs ->store is called with queue freezed, meantime we have several
> > ->store() callbacks(update_nr_requests, wbt, scheduler) to allocate
> > memory with GFP_KERNEL which may run into direct reclaim code path,
> > then potential deadlock can be caused.
> >
> > Fix the issue by marking NOIO around sysfs ->store()
> >
> > Reported-by: Thomas Hellström<thomas.hellstrom@linux.intel.com>
> > Cc:stable@vger.kernel.org
> > Signed-off-by: Ming Lei<ming.lei@redhat.com>
>
> I guess that you should be including a link to https://lore.kernel.org/linux-block/Z4RkemI9f6N5zoEF@fedora/T/#mc774c65eeca5c024d29695f9ac6152b87763f305
>
Indeed, I will add a Closes tag in V2.
> Regardless, FWIW:
> Reviewed-by: John Garry <john.g.garry@oracle.com>
Thanks,
--
Ming
next prev parent reply other threads:[~2025-01-13 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 1:58 [PATCH] block: mark GFP_NOIO around sysfs ->store() Ming Lei
2025-01-13 5:47 ` Christoph Hellwig
2025-01-13 8:23 ` John Garry
2025-01-13 8:29 ` Ming Lei [this message]
2025-01-13 14:46 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2025-08-06 2:50 xu.xin16
2025-08-06 7:27 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4TO8bVgTnB2q4Oz@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).