From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Kun Hu <huk23@m.fudan.edu.cn>,
Jiaji Qin <jjtan24@m.fudan.edu.cn>
Subject: Re: [PATCH] loop: don't call vfs_flush() with queue frozen
Date: Mon, 13 Jan 2025 01:18:00 -0800 [thread overview]
Message-ID: <Z4TaSGZDu_B2GS1c@infradead.org> (raw)
In-Reply-To: <Z4TNW2PYyPUqwLaD@fedora>
On Mon, Jan 13, 2025 at 04:22:51PM +0800, Ming Lei wrote:
> On Sun, Jan 12, 2025 at 09:49:39PM -0800, Christoph Hellwig wrote:
> > On Mon, Jan 13, 2025 at 10:24:26AM +0800, Ming Lei wrote:
> > > If vfs_flush() is called with queue frozen, the queue freeze lock may be
> > > connected with FS internal lock
> >
> > What "FS internal lock" ?
>
> Please see the report:
>
> https://lore.kernel.org/linux-block/359BC288-B0B1-4815-9F01-3A349B12E816@m.fudan.edu.cn/T/#u
Please state the locks. Nothing fs internal here, that report is
about i_rwsem. And a false positive because it is about ordering
of i_rwsem on the upper file system sitting on the loop device vs the
one on the lower file systems sitting below the block device. These
obviously can't deadlock, we just need to tell lockdep about that fact.
next prev parent reply other threads:[~2025-01-13 9:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 2:24 [PATCH] loop: don't call vfs_flush() with queue frozen Ming Lei
2025-01-13 5:49 ` Christoph Hellwig
2025-01-13 8:22 ` Ming Lei
2025-01-13 9:18 ` Christoph Hellwig [this message]
2025-01-13 9:24 ` Ming Lei
2025-01-13 13:49 ` Christoph Hellwig
2025-01-13 15:07 ` Ming Lei
2025-01-15 2:37 ` Ming Lei
2025-01-15 7:05 ` Christoph Hellwig
2025-01-15 8:21 ` Ming Lei
2025-01-15 9:40 ` Christoph Hellwig
2025-01-14 3:21 ` Kun Hu
2025-02-18 5:39 ` Kun Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4TaSGZDu_B2GS1c@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=huk23@m.fudan.edu.cn \
--cc=jjtan24@m.fudan.edu.cn \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).