From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Kun Hu <huk23@m.fudan.edu.cn>,
Jiaji Qin <jjtan24@m.fudan.edu.cn>
Subject: Re: [PATCH] loop: move vfs_fsync() out of loop_update_dio()
Date: Mon, 13 Jan 2025 23:04:51 +0800 [thread overview]
Message-ID: <Z4Urk9NvFqcVhgoS@fedora> (raw)
In-Reply-To: <Z4UaKmN551grXYMn@infradead.org>
On Mon, Jan 13, 2025 at 05:50:34AM -0800, Christoph Hellwig wrote:
> NAK for the same reason as v1. It's not needed because there is no
> deadlock, just a false positive due to missing annotations of lock
Yes, but annotation should be the last straw.
> instances, and we need to fsync with a frozen queue to ensure there
> is no outstanding I/O.
loop_configure() is on unbound loop, so there isn't outstanding I/O.
loop_change_fd() is switching to this new file, so no outstanding I/O
on this new file before unfreeze.
The other two can only switch to buffered IO, which needn't the fsync.
So can you point out anything is wrong?
And this way is sort of simplification.
Thanks,
Ming
next prev parent reply other threads:[~2025-01-13 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 12:06 [PATCH] loop: move vfs_fsync() out of loop_update_dio() Ming Lei
2025-01-13 13:50 ` Christoph Hellwig
2025-01-13 15:04 ` Ming Lei [this message]
2025-01-15 6:59 ` Christoph Hellwig
2025-03-17 8:52 ` 胡焜
2025-03-18 1:07 ` [PATCH] " Ming Lei
2025-04-09 5:49 ` 胡焜
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4Urk9NvFqcVhgoS@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=huk23@m.fudan.edu.cn \
--cc=jjtan24@m.fudan.edu.cn \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).