From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Nilay Shroff <nilay@linux.ibm.com>,
Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH 1/7] block: remove hctx->debugfs_dir
Date: Fri, 14 Feb 2025 10:07:23 +0800 [thread overview]
Message-ID: <Z66lWy5Yf4T_4mlg@fedora> (raw)
In-Reply-To: <20250213064146.GA20494@lst.de>
On Thu, Feb 13, 2025 at 07:41:46AM +0100, Christoph Hellwig wrote:
> On Sun, Feb 09, 2025 at 08:20:25PM +0800, Ming Lei wrote:
> > For each hctx, its debugfs path is fixed, which can be queried from
> > its parent dentry and hctx queue num, so it isn't necessary to cache
> > it in hctx structure because it isn't used in fast path.
>
> It's not needed, but it's also kinda convenient. What is the argument
> that speaks for recalculating the path?
q->debugfs_lock will be not necessary if these cached entries are removed,
please see the last patch.
Thanks,
Ming
next prev parent reply other threads:[~2025-02-14 2:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 12:20 [PATCH 0/7] block: remove all debugfs dir & don't grab debugfs_mutex Ming Lei
2025-02-09 12:20 ` [PATCH 1/7] block: remove hctx->debugfs_dir Ming Lei
2025-02-13 6:41 ` Christoph Hellwig
2025-02-14 2:07 ` Ming Lei [this message]
2025-02-17 9:12 ` Christoph Hellwig
2025-02-09 12:20 ` [PATCH 2/7] block: remove hctx->sched_debugfs_dir Ming Lei
2025-02-13 6:42 ` Christoph Hellwig
2025-02-09 12:20 ` [PATCH 3/7] block: remove q->sched_debugfs_dir Ming Lei
2025-02-09 12:20 ` [PATCH 4/7] block: remove q->rqos_debugfs_dir Ming Lei
2025-02-09 12:20 ` [PATCH 5/7] block: remove rqos->debugfs_dir Ming Lei
2025-02-09 12:20 ` [PATCH 6/7] block: remove q->debugfs_dir Ming Lei
2025-02-09 12:20 ` [PATCH 7/7] block: don't grab q->debugfs_mutex Ming Lei
2025-02-09 16:54 ` kernel test robot
2025-02-10 0:52 ` Shinichiro Kawasaki
2025-02-10 1:42 ` Ming Lei
2025-02-10 7:01 ` Nilay Shroff
2025-02-10 8:15 ` Ming Lei
2025-02-10 8:25 ` Shinichiro Kawasaki
2025-02-10 8:39 ` Nilay Shroff
2025-02-10 13:36 ` Nilay Shroff
2025-02-17 9:41 ` [PATCH 0/7] block: remove all debugfs dir & don't grab debugfs_mutex Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z66lWy5Yf4T_4mlg@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=nilay@linux.ibm.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).