From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1D30267F77 for ; Tue, 25 Feb 2025 11:00:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740481232; cv=none; b=hRuHAEHjFEub0/+beBsNxFIqbjLirCe+Ku0TMCJ135QwGAFH8+3VI7RR8hSAttpL5X/iYS81qVAY3lV1QjROkVW/FxC5vR82YVUEgya7P0CQEZjmqKvc/FOQBSrpWTxCYtPr2hnThXCq+dPOE8UTf/W7gLOQr8pPz8u74DdZghA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740481232; c=relaxed/simple; bh=/9V1fxk2dEGCKZKFBlBO1UY7GGQ4gf7rz3pfp5JbqHs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rf/6/gwe8qK2lrGGm3f9nj/xDN+PtaPTliFhvK2GQXtO2W+MZq2oeotCmbpwPCRajJzFBDku21bQEUlA1AtinPrhiWEB0Ax+ewnLh3qPqjmOGgiTgE46/oLC3KCGoDSUb8GQbzaJK0KoY9clcHFMbeXWVwVw+sI1f51LSbLIgP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qwjl2mEB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qwjl2mEB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740481228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uWOJcVI2y4VAoTGOX/WAROLgGbME7ad1Bieg4/4sn9I=; b=Qwjl2mEBgPd+OcDkapGI0orTZLvwS1w5NEvG4E57w3NlPPUB6spDKAz5TqOHgyoA2YFTWP Xzs6haYH8dgrbUZ+zIQpxfbnpfcrOiTRTynVAZKqMMVbGUUh5RlIbye+9/ET23L89VdWmp oD5riMACePu8UtDjZIhXud0t3jnlB7c= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-2TxgdbmoMQOJ19HkzQlaZg-1; Tue, 25 Feb 2025 06:00:23 -0500 X-MC-Unique: 2TxgdbmoMQOJ19HkzQlaZg-1 X-Mimecast-MFC-AGG-ID: 2TxgdbmoMQOJ19HkzQlaZg_1740481219 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 429D51800998; Tue, 25 Feb 2025 11:00:19 +0000 (UTC) Received: from fedora (unknown [10.72.120.31]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 51F183000197; Tue, 25 Feb 2025 11:00:12 +0000 (UTC) Date: Tue, 25 Feb 2025 19:00:05 +0800 From: Ming Lei To: Keith Busch Cc: asml.silence@gmail.com, axboe@kernel.dk, linux-block@vger.kernel.org, io-uring@vger.kernel.org, bernd@bsbernd.com, csander@purestorage.com, Keith Busch Subject: Re: [PATCHv5 09/11] ublk: zc register/unregister bvec Message-ID: References: <20250224213116.3509093-1-kbusch@meta.com> <20250224213116.3509093-10-kbusch@meta.com> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250224213116.3509093-10-kbusch@meta.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On Mon, Feb 24, 2025 at 01:31:14PM -0800, Keith Busch wrote: > From: Keith Busch > > Provide new operations for the user to request mapping an active request > to an io uring instance's buf_table. The user has to provide the index > it wants to install the buffer. > > A reference count is taken on the request to ensure it can't be > completed while it is active in a ring's buf_table. > > Signed-off-by: Keith Busch > --- > drivers/block/ublk_drv.c | 117 +++++++++++++++++++++++----------- > include/uapi/linux/ublk_cmd.h | 4 ++ > 2 files changed, 85 insertions(+), 36 deletions(-) > > diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c > index 529085181f355..a719d873e3882 100644 > --- a/drivers/block/ublk_drv.c > +++ b/drivers/block/ublk_drv.c > @@ -51,6 +51,9 @@ > /* private ioctl command mirror */ > #define UBLK_CMD_DEL_DEV_ASYNC _IOC_NR(UBLK_U_CMD_DEL_DEV_ASYNC) > > +#define UBLK_IO_REGISTER_IO_BUF _IOC_NR(UBLK_U_IO_REGISTER_IO_BUF) > +#define UBLK_IO_UNREGISTER_IO_BUF _IOC_NR(UBLK_U_IO_UNREGISTER_IO_BUF) > + > /* All UBLK_F_* have to be included into UBLK_F_ALL */ > #define UBLK_F_ALL (UBLK_F_SUPPORT_ZERO_COPY \ > | UBLK_F_URING_CMD_COMP_IN_TASK \ > @@ -201,7 +204,7 @@ static inline struct ublksrv_io_desc *ublk_get_iod(struct ublk_queue *ubq, > int tag); > static inline bool ublk_dev_is_user_copy(const struct ublk_device *ub) > { > - return ub->dev_info.flags & UBLK_F_USER_COPY; > + return ub->dev_info.flags & (UBLK_F_USER_COPY | UBLK_F_SUPPORT_ZERO_COPY); > } I'd suggest to set UBLK_F_USER_COPY explicitly either from userspace or kernel side. One reason is that UBLK_F_UNPRIVILEGED_DEV mode can't work for both. Thanks, Ming