Re: [PATCH 00/11] selftests: ublk: bug fixes & consolidation

[Ming Lei <ming.lei@redhat.com>]

On Mon, Mar 10, 2025 at 09:17:56AM -0600, Jens Axboe wrote:
> On 3/10/25 9:09 AM, Ming Lei wrote:
> > On Mon, Mar 3, 2025 at 8:43?PM Ming Lei <ming.lei@redhat.com> wrote:
> >>
> >> Hello Jens and guys,
> >>
> >> This patchset fixes several issues(1, 2, 4) and consolidate & improve
> >> the tests in the following ways:
> >>
> >> - support shellcheck and fixes all warning
> >>
> >> - misc cleanup
> >>
> >> - improve cleanup code path(module load/unload, cleanup temp files)
> >>
> >> - help to reuse the same test source code and scripts for other
> >>   projects(liburing[1], blktest, ...)
> >>
> >> - add two stress tests for covering IO workloads vs. removing device &
> >> killing ublk server, given buffer lifetime is one big thing for ublk-zc
> >>
> >>
> >> [1] https://github.com/ming1/liburing/commits/ublk-zc
> >>
> >> - just need one line change for overriding skip_code, libring uses 77 and
> >>   kselftests takes 4
> > 
> > Hi Jens,
> > 
> > Can you merge this patchset if you are fine?
> 
> Yep sorry, was pondering how best to get it staged. Should go into
> block, but depends on the other bits that I staged for io_uring. So I'll
> just put it there, not a big deal.

Thanks for pulling it in!

BTW, the test behavior depends on block too, otherwise it may fail because
ublk zc actually depends on the fix of "ublk: complete command synchronously on error".

So if anyone wants to try the test, please do it against next tree.

Thanks,
Ming