From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31BF381E for ; Tue, 11 Mar 2025 04:35:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741667741; cv=none; b=ICtlJoPjQr0yLzygGHFPtwZeqDt0/0HX3OMi8AX0ojx5SuYB/McRK7gAwbu9frU2xFHju3x3gq6DhE48wyxkuQhC48OTbOLzyKps8egqzFN84JBz7pgxvEy2Jf8ci0CV+qM6/ez0UB1JW5SW2iqtiOipeQLxjVKd5yPN9WKxTvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741667741; c=relaxed/simple; bh=+bFQW08Y5h5rVZvOgGOk26oDuZlw1eFCGBNkRGg2Cvc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ck+Ilin4sq7/yda44lG1VYHKHXOJV6n08EnpHLFbtWaBPN+09raFIcxtQmARUgYXkCOHWyU15I6h0UcpUXwTUJrCi7MvuBiyzG55he32kPteIGzfpcnF+8zNAg8dQ4JBzWzbhpH7zjoiq5drEcmL1oRyt9D6bEKKhA0G57G8KMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Jl84OUch; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Jl84OUch" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741667738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RydWn+mrgbEDJyv29iV6STruNKsJ8UhnPiCwUX9hAMc=; b=Jl84OUchBx4mJeFKwZ3MuVkCdcUQXuAAyZahGu3EZA6jVOl9RUv7+Vwo8i+mdKNLI3VvpJ PtVrzA00UVlJuJdyUBVaK0yiN9S4lk7Uxc08J3w7dtZpL8KlziwwcqQ8KNyZZ7PDfXnbuG FZFstm0mNTHesU/HJCoERUEJfMAVgzo= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-WrS50hfXNaWUDGekfwC0yA-1; Tue, 11 Mar 2025 00:35:36 -0400 X-MC-Unique: WrS50hfXNaWUDGekfwC0yA-1 X-Mimecast-MFC-AGG-ID: WrS50hfXNaWUDGekfwC0yA_1741667735 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 22A8A195608A; Tue, 11 Mar 2025 04:35:35 +0000 (UTC) Received: from fedora (unknown [10.72.120.11]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1A5471955BCB; Tue, 11 Mar 2025 04:35:31 +0000 (UTC) Date: Tue, 11 Mar 2025 12:35:26 +0800 From: Ming Lei To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 00/11] selftests: ublk: bug fixes & consolidation Message-ID: References: <20250303124324.3563605-1-ming.lei@redhat.com> <95955f2d-6bcd-492b-9057-37363168bdf5@kernel.dk> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <95955f2d-6bcd-492b-9057-37363168bdf5@kernel.dk> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Mon, Mar 10, 2025 at 09:17:56AM -0600, Jens Axboe wrote: > On 3/10/25 9:09 AM, Ming Lei wrote: > > On Mon, Mar 3, 2025 at 8:43?PM Ming Lei wrote: > >> > >> Hello Jens and guys, > >> > >> This patchset fixes several issues(1, 2, 4) and consolidate & improve > >> the tests in the following ways: > >> > >> - support shellcheck and fixes all warning > >> > >> - misc cleanup > >> > >> - improve cleanup code path(module load/unload, cleanup temp files) > >> > >> - help to reuse the same test source code and scripts for other > >> projects(liburing[1], blktest, ...) > >> > >> - add two stress tests for covering IO workloads vs. removing device & > >> killing ublk server, given buffer lifetime is one big thing for ublk-zc > >> > >> > >> [1] https://github.com/ming1/liburing/commits/ublk-zc > >> > >> - just need one line change for overriding skip_code, libring uses 77 and > >> kselftests takes 4 > > > > Hi Jens, > > > > Can you merge this patchset if you are fine? > > Yep sorry, was pondering how best to get it staged. Should go into > block, but depends on the other bits that I staged for io_uring. So I'll > just put it there, not a big deal. Thanks for pulling it in! BTW, the test behavior depends on block too, otherwise it may fail because ublk zc actually depends on the fix of "ublk: complete command synchronously on error". So if anyone wants to try the test, please do it against next tree. Thanks, Ming