From: Ming Lei <ming.lei@redhat.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Yu Kuai <yukuai1@huaweicloud.com>
Subject: Re: [PATCH] tests/throtl: add a new test 006
Date: Tue, 4 Mar 2025 10:34:51 +0800 [thread overview]
Message-ID: <Z8Zmy91_o7alwuKI@fedora> (raw)
In-Reply-To: <ddvcm7qzw3wxx4wrz6partrr5riobvna75vgcly5cxah76cmmd@w3v3k5yj4daj>
On Mon, Mar 03, 2025 at 12:06:44PM +0000, Shinichiro Kawasaki wrote:
> Hi, Ming, thank you for the patch.
>
> On Feb 24, 2025 / 17:59, Ming Lei wrote:
> > Add test for covering prioritized meta IO when throttling, regression
> > test for commit 29390bb5661d ("blk-throttle: support prioritized processing
> > of metadata").
>
> I ran this test case with the kernel v6.14-rc3, and it passed. Then I reverted
> the commit 29390bb5661d form the kernel, and still the test case passed. I
> wonder how can I make the test case fail. The commit was in v6.12-rc1 tag, so
> do I need to try with v6.11 kernel to see it fails?
>
> I have two nit comments in line. If you respin the patch, please consider to
> fold them in.
The test needs to setup cgroup v1, I guess.
Kuai, any idea for setting one test to cover the change of commit 29390bb5661d
("blk-throttle: support prioritized processing of metadata")?
Thanks,
Ming
prev parent reply other threads:[~2025-03-04 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 9:59 [PATCH] tests/throtl: add a new test 006 Ming Lei
2025-02-24 12:25 ` Yu Kuai
2025-02-24 13:54 ` Ming Lei
2025-02-25 2:07 ` Yu Kuai
2025-03-04 2:46 ` Yu Kuai
2025-03-04 10:02 ` Ming Lei
2025-03-04 13:08 ` Yu Kuai
2025-03-03 12:06 ` Shinichiro Kawasaki
2025-03-04 2:34 ` Ming Lei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8Zmy91_o7alwuKI@fedora \
--to=ming.lei@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox