From: Tejun Heo <tj@kernel.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
Yu Kuai <yukuai3@huawei.com>
Subject: Re: [PATCH 3/3] blk-throttle: carry over directly
Date: Wed, 5 Mar 2025 09:16:09 -1000 [thread overview]
Message-ID: <Z8ii-QViMUjOoYgt@slm.duckdns.org> (raw)
In-Reply-To: <20250305043123.3938491-4-ming.lei@redhat.com>
On Wed, Mar 05, 2025 at 12:31:21PM +0800, Ming Lei wrote:
> Now ->carryover_bytes[] and ->carryover_ios[] only covers limit/config
> update.
>
> Actually the carryover bytes/ios can be carried to ->bytes_disp[] and
> ->io_disp[] directly, since the carryover is one-shot thing and only valid
> in current slice.
>
> Then we can remove the two fields and simplify code much.
>
> Type of ->bytes_disp[] and ->io_disp[] has to change as signed because the
> two fields may become negative when updating limits or config, but both are
> big enough for holding bytes/ios dispatched in single slice
>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: Yu Kuai <yukuai3@huawei.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2025-03-05 19:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 4:31 [PATCH 0/3] blk-throttle: remove last_bytes/ios and carryover byte/ios Ming Lei
2025-03-05 4:31 ` [PATCH 1/3] blk-throttle: remove last_bytes_disp and last_ios_disp Ming Lei
2025-03-05 19:07 ` Tejun Heo
2025-03-05 4:31 ` [PATCH 2/3] blk-throttle: don't take carryover for prioritized processing of metadata Ming Lei
2025-03-05 19:11 ` Tejun Heo
2025-03-05 4:31 ` [PATCH 3/3] blk-throttle: carry over directly Ming Lei
2025-03-05 19:16 ` Tejun Heo [this message]
2025-04-11 2:53 ` Yu Kuai
2025-04-11 15:01 ` Ming Lei
2025-04-12 0:37 ` Yu Kuai
2025-04-14 2:32 ` Ming Lei
2025-04-14 11:47 ` Yu Kuai
2025-03-05 23:25 ` [PATCH 0/3] blk-throttle: remove last_bytes/ios and carryover byte/ios Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8ii-QViMUjOoYgt@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox