From: Keith Busch <kbusch@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: Kent Overstreet <kent.overstreet@linux.dev>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH] block: Allow REQ_FUA|REQ_READ
Date: Tue, 11 Mar 2025 09:13:19 -0600 [thread overview]
Message-ID: <Z9BTD_T3sEzk-Nim@kbusch-mbp> (raw)
In-Reply-To: <Z9BOf7WljNX-Rnl7@ryzen>
On Tue, Mar 11, 2025 at 03:53:51PM +0100, Niklas Cassel wrote:
> So IIUC, at least for ATA, if something is corrupted in the volatile
> write cache, setting the FUA bit will ensure that the corruption will
> get propagated to the non-volatile media.
It's not necessarily going to corrupt persistent media if the volatile
write cache is corrupted. It should just apply only to data written to
the volatile write cache that hasn't been flushed to the media. If the
device reads persisted media data into a corrupted cache, the FUA here
should catch that and see good data.
But if you haven't flushed previous writes from a corrupted volatile
write cache, then I believe you're right: the read FUA will presist that
corruption. Same is true for NVMe.
next prev parent reply other threads:[~2025-03-11 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 13:35 [PATCH] block: Allow REQ_FUA|REQ_READ Kent Overstreet
2025-03-11 14:53 ` Niklas Cassel
2025-03-11 15:09 ` Kent Overstreet
2025-03-11 15:13 ` Keith Busch [this message]
2025-03-11 15:02 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9BTD_T3sEzk-Nim@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox