public inbox for linux-block@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
	linux-btrfs@vger.kernel.org, axboe@kernel.dk,
	linux-block@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH v2 1/2] block: introduce zone capacity helper
Date: Mon, 17 Mar 2025 22:54:06 -0700	[thread overview]
Message-ID: <Z9kKfpY0E-phdJ5G@infradead.org> (raw)
In-Reply-To: <2a641d02-1d59-4e0b-9dcc-defb64548d1b@kernel.org>

On Tue, Mar 18, 2025 at 02:14:29PM +0900, Damien Le Moal wrote:
> @pos is not the start of the zone, so this should be:
> 
>  * disk_zone_capacity - returns the capacity of the zone containing @sect
> 
> And rename pos to sect.

While we're nitpicking:  sect is a bit weird, the block layer usually
spells it out as sectors (sect sounds too close to the german word for
sparkling wine anyway :))


  reply	other threads:[~2025-03-18  5:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18  0:59 [PATCH v2 0/2] btrfs: zoned: skip reporting zone for new block group Naohiro Aota
2025-03-18  0:59 ` [PATCH v2 1/2] block: introduce zone capacity helper Naohiro Aota
2025-03-18  5:14   ` Damien Le Moal
2025-03-18  5:54     ` Christoph Hellwig [this message]
2025-03-18  7:57       ` Damien Le Moal
2025-03-18  8:04         ` Christoph Hellwig
2025-03-18  7:27   ` Johannes Thumshirn
2025-03-18  0:59 ` [PATCH v2 2/2] btrfs: zoned: skip reporting zone for new block group Naohiro Aota
2025-03-18  7:25   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9kKfpY0E-phdJ5G@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox