From: Uday Shankar <ushankar@purestorage.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH] ublk: remove io_cmds list in ublk_queue
Date: Tue, 18 Mar 2025 15:58:38 -0600 [thread overview]
Message-ID: <Z9nsjiynsQ9gRPv7@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <097f0495-b2e8-4938-9a0d-c321f618d49b@kernel.dk>
On Tue, Mar 18, 2025 at 12:48:44PM -0600, Jens Axboe wrote:
> > though I don't see any examples of drivers using it. Would it be a bad
> > idea to try and reuse that?
>
> We can't reuse that one, and it's not for driver use - purely internal.
> But I _think_ you could easily grab space in the union that has the hash
> and ipi_list for it. And then you could dump needing this extra data per
> request.
Another idea is to union the refcount with end_io_data, since that's
purely for the driver. But it might be a bit weird to tell drivers that
they can use either end_io/end_io_data or the refcount but not both...
not to mention it could be a nice exploit vector if drivers get it
wrong.
Either way, I think this work is follow-on material and shouldn't be
rolled into this patch.
next prev parent reply other threads:[~2025-03-18 21:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 18:14 [PATCH] ublk: remove io_cmds list in ublk_queue Uday Shankar
2025-03-18 18:22 ` Jens Axboe
2025-03-18 18:43 ` Uday Shankar
2025-03-18 18:48 ` Jens Axboe
2025-03-18 21:58 ` Uday Shankar [this message]
2025-03-19 1:54 ` Jens Axboe
2025-03-19 1:04 ` Ming Lei
2025-03-19 1:57 ` Jens Axboe
2025-03-19 2:14 ` Ming Lei
2025-03-19 12:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9nsjiynsQ9gRPv7@dev-ushankar.dev.purestorage.com \
--to=ushankar@purestorage.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox