Linux block layer
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Yu Kuai <yukuai1@huaweicloud.com>
Cc: jack@suse.cz, hare@suse.de, hch@infradead.org, axboe@kernel.dk,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	yi.zhang@huawei.com, yangerkun@huawei.com,
	"yukuai (C)" <yukuai3@huawei.com>,
	Changhui Zhong <czhong@redhat.com>
Subject: Re: [PATCH -next 0/2] block: fix scan partition for exclusively open device again
Date: Wed, 22 Mar 2023 09:34:16 +0800	[thread overview]
Message-ID: <ZBpbGKxPQcs9NYst@ovpn-8-18.pek2.redhat.com> (raw)
In-Reply-To: <dc7d28bf-35ca-7cde-ffdf-9490177dfdb9@huaweicloud.com>

On Wed, Mar 22, 2023 at 09:26:07AM +0800, Yu Kuai wrote:
> Hi,
> 
> 在 2023/03/21 19:43, Ming Lei 写道:
> > On Fri, Feb 17, 2023 at 10:21:58AM +0800, Yu Kuai wrote:
> > > From: Yu Kuai <yukuai3@huawei.com>
> > > 
> > > Changes from RFC:
> > >   - remove the patch to factor out GD_NEED_PART_SCAN
> > > 
> > > Yu Kuai (2):
> > >    block: Revert "block: Do not reread partition table on exclusively
> > >      open device"
> > >    block: fix scan partition for exclusively open device again
> > 
> > Hi Yu kuai,
> > 
> > Looks the original issue starts to re-appear now with the two patches:
> > 
> > https://lore.kernel.org/linux-block/20221130135344.2ul4cyfstfs3znxg@quack3/
> > 
> > And underlying disk partition and raid partition can be observed at the
> > same time.
> > 
> > Can you take a look?
> Yes, thanks for the report. I realize that sda1 adn sdb1 is created
> while raid open sda and sdb excl, and I think this problem should exist
> before this patchset.

Looks not reproduced before applying your two patches, that is exactly what Jan
tried to fix with 36369f46e917 ("block: Do not reread partition table on exclusively open device").

The issue is reported by Changhui's block regression test.


Thanks, 
Ming


  reply	other threads:[~2023-03-22  1:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17  2:21 [PATCH -next 0/2] block: fix scan partition for exclusively open device again Yu Kuai
2023-02-17  2:21 ` [PATCH -next 1/2] block: Revert "block: Do not reread partition table on exclusively open device" Yu Kuai
2023-02-17 11:01   ` Jan Kara
2023-02-17  2:22 ` [PATCH -next 2/2] block: fix scan partition for exclusively open device again Yu Kuai
2023-02-17  7:29   ` Christoph Hellwig
2023-02-17 11:05   ` Jan Kara
2023-02-17 13:16 ` [PATCH -next 0/2] " Jens Axboe
2023-03-21 11:43 ` Ming Lei
2023-03-22  1:26   ` Yu Kuai
2023-03-22  1:34     ` Ming Lei [this message]
2023-03-22  2:02       ` Yu Kuai
2023-03-22  2:15         ` Yu Kuai
2023-03-22  3:38           ` Ming Lei
2023-03-22  4:00             ` Yu Kuai
2023-03-22  3:59   ` [PATCH] block: don't set GD_NEED_PART_SCAN if scan partition failed Yu Kuai
2023-03-22  7:58     ` Ming Lei
2023-03-22  9:12       ` Yu Kuai
2023-03-22  9:47       ` Jan Kara
2023-03-22 11:34         ` Ming Lei
2023-03-22 13:07           ` Jan Kara
2023-03-22 16:08             ` Ming Lei
2023-03-23 10:51               ` Jan Kara
2023-03-23 12:03                 ` Ming Lei
2023-03-22  9:52     ` Jan Kara
2023-03-23 23:59     ` Ming Lei
2023-04-06  3:42     ` Yu Kuai
2023-04-06 22:29       ` Jens Axboe
2023-04-07  2:01         ` Ming Lei
2023-04-07  2:42           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBpbGKxPQcs9NYst@ovpn-8-18.pek2.redhat.com \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=czhong@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai1@huaweicloud.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox