From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-block-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9399CC6FD1D
	for <linux-block@archiver.kernel.org>; Mon, 27 Mar 2023 22:12:09 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229598AbjC0WMI (ORCPT <rfc822;linux-block@archiver.kernel.org>);
        Mon, 27 Mar 2023 18:12:08 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46748 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229493AbjC0WMH (ORCPT
        <rfc822;linux-block@vger.kernel.org>);
        Mon, 27 Mar 2023 18:12:07 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB39CD8
        for <linux-block@vger.kernel.org>; Mon, 27 Mar 2023 15:12:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=BcuSuhNQwJ6ESX0y6ReUQuU7zU2SiU2lDX0qhPDN4QA=; b=Iz5qC49TSnJAHOSWBB5e/uHEqF
        W6eMGD6+s5I4kbLdnCnVn7bv2dPKPbDH8Fmz2CSwY4AWXvV1yB1QQceplxuBya5DZJMMxva5qaxlc
        psdUMb62dTNNgohXdrMuuK7wxNcvstfKpVVlirbFqU2P6qsrF34HelevdfoQA7QUDNMxIInt4666G
        cBBvRE5Dczvkgp24bM1/LicUv1ZF8Iwt/S/eTJ1sdnMXamR8pSZ3O1bVpknsp5ZybnpyIwW4ZCVUd
        rOo0MEtRQO5q4tXOeM1ZJPip4vnDRCfW6zubuzKEqNM6K0+jBmWZL+uaYVT1qidrDPwUW34WNUchu
        058IoiHQ==;
Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux))
        id 1pgv4P-00CUwj-0a;
        Mon, 27 Mar 2023 22:12:05 +0000
Date:   Mon, 27 Mar 2023 15:12:05 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Chaitanya Kulkarni <kch@nvidia.com>
Cc:     linux-block@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH 1/2] block: open code __blk_account_io_start()
Message-ID: <ZCIUtZGOaxIza3j3@infradead.org>
References: <20230327073427.4403-1-kch@nvidia.com>
 <20230327073427.4403-2-kch@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230327073427.4403-2-kch@nvidia.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Precedence: bulk
List-ID: <linux-block.vger.kernel.org>
X-Mailing-List: linux-block@vger.kernel.org

On Mon, Mar 27, 2023 at 12:34:26AM -0700, Chaitanya Kulkarni wrote:
> There is only one caller for __blk_account_io_start(), the function
> is small enough to fit in its caller blk_account_io_start().
> 
> Remove the function and opencode in the its caller
> blk_account_io_start().

Having the account slow path in a separate function actually is nice,
same for the next patch.

> +		/*
> +		 * All non-passthrough requests are created from a bio with one
> +		 * exception: when a flush command that is part of a flush sequence
> +		 * generated by the state machine in blk-flush.c is cloned onto the
> +		 * lower device by dm-multipath we can get here without a bio.
> +		 */

... and now you've created a totally messed up block comment expanding
over 80 characters.